Fix improperly adjusted external allocated memory on weak callback call

pinepain · pinepain · commit 305ecb2e60ca · 2017-09-16T14:00:08.000+03:00
diff --git a/src/php_v8_value.cc b/src/php_v8_value.cc
@@ -67,9 +67,6 @@ static void php_v8_value_weak_callback(const v8::WeakCallbackInfo<v8::Persistent
 
     data.GetParameter()->Reset();
     delete data.GetParameter();
-
-    // Tell v8 that we release external allocated memory
-    isolate->AdjustAmountOfExternalAllocatedMemory(-1024 * 1024 * 1024);
 }
 
 static void php_v8_value_make_weak(php_v8_value_t *php_v8_value) {

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,6 @@ static void php_v8_value_weak_callback(const v8::WeakCallbackInfo<v8::Persistent`
`67`	`67`
`68`	`68`	`data.GetParameter()->Reset();`
`69`	`69`	`delete data.GetParameter();`
`70`		`-`
`71`		`- // Tell v8 that we release external allocated memory`
`72`		`- isolate->AdjustAmountOfExternalAllocatedMemory(-1024 * 1024 * 1024);`
`73`	`70`	`}`
`74`	`71`
`75`	`72`	`static void php_v8_value_make_weak(php_v8_value_t *php_v8_value) {`