Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 530a85f

Browse files
committed
[doc] Update reference to new v8 in cmake file [skip ci]
1 parent fc6b747 commit 530a85f

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

Diff for: CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ project(php-v8)
33

44
# NOTE: This CMake file is just for syntax highlighting in CLion
55

6-
include_directories(/usr/local/opt/v8@6.3/include)
7-
include_directories(/usr/local/opt/v8@6.3/include/libplatform)
6+
include_directories(/usr/local/opt/v8@6.4/include)
7+
include_directories(/usr/local/opt/v8@6.4/include/libplatform)
88

99
include_directories(/usr/local/include/php)
1010
include_directories(/usr/local/include/php/TSRM)

Diff for: docs/development/release-libv8.md

+8-7
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,19 @@ To track v8 changes you can use these links:
3535
1. Update min required `libv8` version in [php-v8](https://github.com/pinepain/php-v8)/config.m4, `V8_MIN_API_VERSION_STR=X.Y.Z`.
3636
2. If there was new docker images published, update reference to them in [php-v8](https://github.com/pinepain/php-v8)/.travis.yml
3737
and in [php-v8](https://github.com/pinepain/php-v8)/Dockerfile, and set proper `V8` and `TAG` value there.
38-
3. Also, update references to v8 version in [php-v8](https://github.com/pinepain/php-v8)/scripts/provision/provision.sh,
38+
3. Update reference to `[email protected]` in [php-v8](https://github.com/pinepain/php-v8)/CMakeLists.txt on minor version bump.
39+
4. Also, update references to v8 version in [php-v8](https://github.com/pinepain/php-v8)/scripts/provision/provision.sh,
3940
it's normally could be done by replacing old version with new, e.g. `6.3` => `6.4`.
40-
4. On every version bump update [php-v8](https://github.com/pinepain/php-v8)/README.md file with proper min v8 version required/tested.
41-
5. If you use vagrant, re-provision your local dev env at this step to fetch/add new `libv8` version.
41+
5. On every version bump update [php-v8](https://github.com/pinepain/php-v8)/README.md file with proper min v8 version required/tested.
42+
6. If you use vagrant, re-provision your local dev env at this step to fetch/add new `libv8` version.
4243
It's generally a good idea to remove old `libv8` versions as well and remove their PPA from apt sources list at this point.
43-
6. **Make sure you tested [php-v8](https://github.com/pinepain/php-v8) locally first before pushing to remote**,
44+
7. **Make sure you tested [php-v8](https://github.com/pinepain/php-v8) locally first before pushing to remote**,
4445
upgrading v8 could be tricky as it may break BC even in patch releases (that's why we started to have separate
4546
PPAs for minor version to somehow couple with this issue in minor releases).
46-
7. Note, that doing all this in a separate branch and merging that later into master is a nice and safe idea
47+
8. Note, that doing all this in a separate branch and merging that later into master is a nice and safe idea
4748
(note, you may skip PR overhead and do fast-forward merge locally to master).
48-
8. Commit message should state that it is v8 version bump, e.g. `Require libv8 >= X.Y.Z`
49-
9. Push changes and make sure build is green. If not, fix code/update tests and repeat.
49+
9. Commit message should state that it is v8 version bump, e.g. `Require libv8 >= X.Y.Z`
50+
10. Push changes and make sure build is green. If not, fix code/update tests and repeat.
5051

5152

5253
## Building packages for macOS Homebrew

0 commit comments

Comments
 (0)