@@ -35,18 +35,19 @@ To track v8 changes you can use these links:
35
35
1 . Update min required ` libv8 ` version in [ php-v8] ( https://github.com/pinepain/php-v8 ) /config.m4, ` V8_MIN_API_VERSION_STR=X.Y.Z ` .
36
36
2 . If there was new docker images published, update reference to them in [ php-v8] ( https://github.com/pinepain/php-v8 ) /.travis.yml
37
37
and in [ php-v8] ( https://github.com/pinepain/php-v8 ) /Dockerfile, and set proper ` V8 ` and ` TAG ` value there.
38
- 3 . Also, update references to v8 version in [ php-v8] ( https://github.com/pinepain/php-v8 ) /scripts/provision/provision.sh,
38
+ 3 . Update reference to
` [email protected] ` in
[ php-v8
] ( https://github.com/pinepain/php-v8 ) /CMakeLists.txt on minor version bump.
39
+ 4 . Also, update references to v8 version in [ php-v8] ( https://github.com/pinepain/php-v8 ) /scripts/provision/provision.sh,
39
40
it's normally could be done by replacing old version with new, e.g. ` 6.3 ` => ` 6.4 ` .
40
- 4 . On every version bump update [ php-v8] ( https://github.com/pinepain/php-v8 ) /README.md file with proper min v8 version required/tested.
41
- 5 . If you use vagrant, re-provision your local dev env at this step to fetch/add new ` libv8 ` version.
41
+ 5 . On every version bump update [ php-v8] ( https://github.com/pinepain/php-v8 ) /README.md file with proper min v8 version required/tested.
42
+ 6 . If you use vagrant, re-provision your local dev env at this step to fetch/add new ` libv8 ` version.
42
43
It's generally a good idea to remove old ` libv8 ` versions as well and remove their PPA from apt sources list at this point.
43
- 6 . ** Make sure you tested [ php-v8] ( https://github.com/pinepain/php-v8 ) locally first before pushing to remote** ,
44
+ 7 . ** Make sure you tested [ php-v8] ( https://github.com/pinepain/php-v8 ) locally first before pushing to remote** ,
44
45
upgrading v8 could be tricky as it may break BC even in patch releases (that's why we started to have separate
45
46
PPAs for minor version to somehow couple with this issue in minor releases).
46
- 7 . Note, that doing all this in a separate branch and merging that later into master is a nice and safe idea
47
+ 8 . Note, that doing all this in a separate branch and merging that later into master is a nice and safe idea
47
48
(note, you may skip PR overhead and do fast-forward merge locally to master).
48
- 8 . Commit message should state that it is v8 version bump, e.g. ` Require libv8 >= X.Y.Z `
49
- 9 . Push changes and make sure build is green. If not, fix code/update tests and repeat.
49
+ 9 . Commit message should state that it is v8 version bump, e.g. ` Require libv8 >= X.Y.Z `
50
+ 10 . Push changes and make sure build is green. If not, fix code/update tests and repeat.
50
51
51
52
52
53
## Building packages for macOS Homebrew
0 commit comments