Introduce V8\Undefined value and make conatiner classes abstract

Author: pinepain

config.m4

@@ -175,6 +175,7 @@ if test "$PHP_V8" != "no"; then
     src/php_v8_data.cc                                    \
     src/php_v8_value.cc                                   \
     src/php_v8_primitive.cc                               \
+    src/php_v8_undefined.cc                               \
     src/php_v8_null.cc                                    \
     src/php_v8_boolean.cc                                 \
     src/php_v8_name.cc                                    \

src/php_v8_name.cc

@@ -58,6 +58,7 @@ PHP_MINIT_FUNCTION(php_v8_name)
     zend_class_entry ce;
     INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "NameValue", php_v8_name_methods);
     this_ce = zend_register_internal_class_ex(&ce, php_v8_primitive_class_entry);
+    this_ce->ce_flags |= ZEND_ACC_EXPLICIT_ABSTRACT_CLASS;
 
     return SUCCESS;
 }

src/php_v8_primitive.cc

@@ -32,6 +32,7 @@ PHP_MINIT_FUNCTION(php_v8_primitive)
     zend_class_entry ce;
     INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "PrimitiveValue", php_v8_primitive_methods);
     this_ce = zend_register_internal_class_ex(&ce, php_v8_value_class_entry);
+    this_ce->ce_flags |= ZEND_ACC_EXPLICIT_ABSTRACT_CLASS;
 
     return SUCCESS;
 }

src/php_v8_undefined.cc

@@ -0,0 +1,56 @@
+/*
+ * This file is part of the pinepain/php-v8 PHP extension.
+ *
+ * Copyright (c) 2015-2017 Bogdan Padalko <[email protected]>
+ *
+ * Licensed under the MIT license: http://opensource.org/licenses/MIT
+ *
+ * For the full copyright and license information, please view the
+ * LICENSE file that was distributed with this source or visit
+ * http://opensource.org/licenses/MIT
+ */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "php_v8_undefined.h"
+#include "php_v8_primitive.h"
+#include "php_v8_value.h"
+#include "php_v8.h"
+
+zend_class_entry *php_v8_undefined_class_entry;
+#define this_ce php_v8_undefined_class_entry
+
+
+static PHP_METHOD(V8Undefined, __construct) {
+    zval *php_v8_isolate_zv;
+
+    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &php_v8_isolate_zv) == FAILURE) {
+        return;
+    }
+
+    PHP_V8_VALUE_CONSTRUCT(getThis(), php_v8_isolate_zv, php_v8_isolate, php_v8_value);
+
+    php_v8_value->persistent->Reset(isolate, v8::Undefined(isolate));
+}
+
+
+ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_undefined___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 1)
+                ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
+ZEND_END_ARG_INFO()
+
+
+static const zend_function_entry php_v8_undefined_methods[] = {
+        PHP_ME(V8Undefined, __construct, arginfo_v8_undefined___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
+        PHP_FE_END
+};
+
+
+PHP_MINIT_FUNCTION(php_v8_undefined) {
+    zend_class_entry ce;
+    INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "UndefinedValue", php_v8_undefined_methods);
+    this_ce = zend_register_internal_class_ex(&ce, php_v8_primitive_class_entry);
+
+    return SUCCESS;
+}

src/php_v8_undefined.h

@@ -0,0 +1,29 @@
+/*
+ * This file is part of the pinepain/php-v8 PHP extension.
+ *
+ * Copyright (c) 2015-2017 Bogdan Padalko <[email protected]>
+ *
+ * Licensed under the MIT license: http://opensource.org/licenses/MIT
+ *
+ * For the full copyright and license information, please view the
+ * LICENSE file that was distributed with this source or visit
+ * http://opensource.org/licenses/MIT
+ */
+
+#ifndef PHP_V8_UNDEFINED_H
+#define PHP_V8_UNDEFINED_H
+
+extern "C" {
+#include "php.h"
+
+#ifdef ZTS
+#include "TSRM.h"
+#endif
+}
+
+extern zend_class_entry* php_v8_undefined_class_entry;
+
+
+PHP_MINIT_FUNCTION(php_v8_undefined);
+
+#endif //PHP_V8_UNDEFINED_H

src/php_v8_value.cc

@@ -38,6 +38,7 @@
 #include "php_v8_uint32.h"
 #include "php_v8_integer.h"
 #include "php_v8_number.h"
+#include "php_v8_undefined.h"
 /* end of type listing */
 
 #include "php_v8_data.h"
@@ -231,7 +232,7 @@ zend_class_entry *php_v8_get_class_entry_from_value(v8::Local<v8::Value> value)
     // working with scalars
 
     if (value->IsUndefined()) {
-        return php_v8_value_class_entry;
+        return php_v8_undefined_class_entry;
     }
 
     if (value->IsNull()) {
@@ -313,17 +314,15 @@ php_v8_value_t *php_v8_get_or_create_value(zval *return_value, v8::Local<v8::Val
 }
 
 
-static PHP_METHOD (V8Value, __construct) {
-    zval *php_v8_isolate_zv;
-
-    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &php_v8_isolate_zv) == FAILURE) {
-        return;
-    }
-
-    PHP_V8_VALUE_CONSTRUCT(getThis(), php_v8_isolate_zv, php_v8_isolate, php_v8_value);
-
-    php_v8_value->persistent->Reset(isolate, v8::Undefined(isolate));
-}
+//static PHP_METHOD (V8Value, __construct) {
+//    zval *php_v8_isolate_zv;
+//
+//    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &php_v8_isolate_zv) == FAILURE) {
+//        return;
+//    }
+//
+//    PHP_V8_THROW_EXCEPTION("V8\\Value::__construct() should not be called. Use specific values instead.")
+//}
 
 static PHP_METHOD(V8Value, GetIsolate) {
     zval rv;
@@ -1062,7 +1061,8 @@ ZEND_END_ARG_INFO()
 
 
 static const zend_function_entry php_v8_value_methods[] = {
-        PHP_ME(V8Value, __construct, arginfo_v8_value___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
+//        PHP_ME(V8Value, __construct, arginfo_v8_value___construct, ZEND_ACC_PRIVATE | ZEND_ACC_CTOR)
+
         PHP_ME(V8Value, GetIsolate, arginfo_v8_value_GetIsolate, ZEND_ACC_PUBLIC)
 
         PHP_ME(V8Value, IsUndefined,                    arginfo_v8_value_IsUndefined,                   ZEND_ACC_PUBLIC)
@@ -1146,6 +1146,7 @@ PHP_MINIT_FUNCTION (php_v8_value) {
     INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "Value", php_v8_value_methods);
     this_ce = zend_register_internal_class_ex(&ce, php_v8_data_class_entry);
     this_ce->create_object = php_v8_value_ctor;
+    this_ce->ce_flags |= ZEND_ACC_EXPLICIT_ABSTRACT_CLASS;
 
     zend_declare_property_null(this_ce, ZEND_STRL("isolate"), ZEND_ACC_PRIVATE);
 

stubs/src/ArrayObject.php

@@ -30,7 +30,6 @@ class ArrayObject extends ObjectValue
      */
     public function __construct(Context $context, int $length = 0)
     {
-        parent::__construct($context);
     }
 
     /**

stubs/src/BooleanObject.php

@@ -27,7 +27,6 @@ class BooleanObject extends ObjectValue
      */
     public function __construct(Context $context, bool $value)
     {
-        parent::__construct($context);
     }
 
     /**

stubs/src/BooleanValue.php

@@ -27,7 +27,6 @@ class BooleanValue extends PrimitiveValue
      */
     public function __construct(Isolate $isolate, bool $value)
     {
-        parent::__construct($isolate);
     }
 
     /**

stubs/src/NameValue.php

@@ -19,7 +19,7 @@
 /**
  * A superclass for symbols and strings.
  */
-class NameValue extends PrimitiveValue
+abstract class NameValue extends PrimitiveValue
 {
     /**
      * Returns the identity hash for this object. The current implementation