Add support for ScriptCompiler::kProduceFullCodeCache, closes #71

Author: pinepain

src/php_v8_script_compiler.cc

@@ -292,11 +292,12 @@ PHP_MINIT_FUNCTION(php_v8_script_compiler)
     INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "ScriptCompiler", php_v8_script_compiler_methods);
     this_ce = zend_register_internal_class(&ce);
 
-    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_NO_COMPILE_OPTIONS"),   static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kNoCompileOptions));
-    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_PRODUCE_PARSER_CACHE"), static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kProduceParserCache));
-    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_CONSUME_PARSER_CACHE"), static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kConsumeParserCache));
-    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_PRODUCE_CODE_CACHE"),   static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kProduceCodeCache));
-    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_CONSUME_CODE_CACHE"),   static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kConsumeCodeCache));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_NO_COMPILE_OPTIONS"),      static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kNoCompileOptions));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_PRODUCE_PARSER_CACHE"),    static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kProduceParserCache));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_CONSUME_PARSER_CACHE"),    static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kConsumeParserCache));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_PRODUCE_CODE_CACHE"),      static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kProduceCodeCache));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_PRODUCE_FULL_CODE_CACHE"), static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kProduceFullCodeCache));
+    zend_declare_class_constant_long(this_ce, ZEND_STRL("OPTION_CONSUME_CODE_CACHE"),      static_cast<zend_long>(v8::ScriptCompiler::CompileOptions::kConsumeCodeCache));
 
     return SUCCESS;
 }

stubs/src/ScriptCompiler.php

@@ -12,6 +12,13 @@
  */
 class  ScriptCompiler
 {
+    const OPTION_NO_COMPILE_OPTIONS = 0;
+    const OPTION_PRODUCE_PARSER_CACHE = 1;
+    const OPTION_CONSUME_PARSER_CACHE = 2;
+    const OPTION_PRODUCE_CODE_CACHE = 3;
+    const OPTION_PRODUCE_FULL_CODE_CACHE = 4;
+    const OPTION_CONSUME_CODE_CACHE = 5;
+
     private function __construct()
     {
     }

tests/001-verify_extension_entities.phpt

@@ -13,8 +13,8 @@ class Dumper
     {
         $re = new ReflectionExtension('v8');
 
-        echo 'Name: ', $re->getName(), PHP_EOL;
-        echo 'Version: ', $re->getVersion(), PHP_EOL;
+        // echo 'Name: ', $re->getName(), PHP_EOL;
+        // echo 'Version: ', $re->getVersion(), PHP_EOL;
 
         echo PHP_EOL;
         echo 'Extension-global functions:', PHP_EOL;
@@ -204,14 +204,8 @@ $d = new Dumper();
 
 $d->dumpExtension();
 
-// EXPECTF: ---/Version: .+/
-// EXPECTF: +++Version: %s
-
 ?>
---EXPECTF--
-Name: v8
-Version: %s
-
+--EXPECT--
 Extension-global functions:
 none
 
@@ -412,6 +406,7 @@ class V8\ScriptCompiler
     const OPTION_PRODUCE_PARSER_CACHE = 1
     const OPTION_CONSUME_PARSER_CACHE = 2
     const OPTION_PRODUCE_CODE_CACHE = 3
+    const OPTION_PRODUCE_FULL_CODE_CACHE = 4
     const OPTION_CONSUME_CODE_CACHE = 5
     public static function cachedDataVersionTag(): int
     public static function compileUnboundScript(V8\Context $context, V8\ScriptCompiler\Source $source, int $options): V8\UnboundScript

tests/ScriptCompiler_compile.phpt

@@ -104,6 +104,31 @@ $cache_data = null;
     $helper->line();
 }
 
+{
+    $helper->header('Test generating full code cache');
+    $source_string = new V8\StringValue($isolate, '"test " + status');
+    $source = new \V8\ScriptCompiler\Source($source_string);
+    $helper->assert('Source cache data is NULL', $source->getCachedData() === null);
+    $script = V8\ScriptCompiler::compile($context, $source, V8\ScriptCompiler::OPTION_PRODUCE_FULL_CODE_CACHE);
+    $helper->assert('Source cache data is update', $source->getCachedData() != null);
+    $helper->assert('Source cache data is not rejected', $source->getCachedData()->isRejected() === false);
+
+    $cache_data = $source->getCachedData();
+    $helper->line();
+}
+
+{
+    $helper->header('Test consuming full code cache');
+
+    $source = new \V8\ScriptCompiler\Source($source_string, null, $cache_data);
+    $helper->assert('Source cache data is set', $source->getCachedData() != null);
+    $script = V8\ScriptCompiler::compile($context, $source, V8\ScriptCompiler::OPTION_CONSUME_CODE_CACHE);
+    $helper->assert('Source cache data is still set', $source->getCachedData() != null);
+    $helper->assert('Source cache data is not rejected', $source->getCachedData()->isRejected() === false);
+
+    $helper->line();
+}
+
 {
     $helper->header('Test consuming code cache for wrong source');
     $source_string = new V8\StringValue($isolate, '"other " + status');
@@ -292,6 +317,18 @@ Source cache data is set: ok
 Source cache data is still set: ok
 Source cache data is not rejected: ok
 
+Test generating full code cache:
+--------------------------------
+Source cache data is NULL: ok
+Source cache data is update: ok
+Source cache data is not rejected: ok
+
+Test consuming full code cache:
+-------------------------------
+Source cache data is set: ok
+Source cache data is still set: ok
+Source cache data is not rejected: ok
+
 Test consuming code cache for wrong source:
 -------------------------------------------
 Source cache data is set: ok