Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit d8345d8

Browse files
committed
Update and fix readme links [skip ci]
1 parent eb2397c commit d8345d8

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

Diff for: README.md

+9-7
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ intentionally with the purpose to provide more solid experience between native V
4040

4141
## Demo
4242

43-
Here is a [Hello World](https://developers.google.com/v8/get_started#hello-world)
44-
from V8 [Getting Started](https://developers.google.com/v8/intro) developers guide page implemented in PHP with php-v8:
43+
Here is a [Hello World][v8-hello-world]
44+
from V8 [Getting Started][v8-intro] developers guide page implemented in PHP with php-v8:
4545

4646
```php
4747
<?php
@@ -55,8 +55,8 @@ $result = $script->Run($context);
5555
echo $result->ToString($context)->Value(), PHP_EOL;
5656
```
5757

58-
which will output `Hello, World!`. See how it's shorter and readable from that C++ version? And it also doesn't limit
59-
you from V8 API utilizing to implement more amazing stuff.
58+
which will output `Hello, World!`. See how it's shorter and readable from [that C++ version]([v8-hello-world])?
59+
And it also doesn't limit you from V8 API utilizing to implement more amazing stuff.
6060

6161

6262
## Installation
@@ -103,11 +103,11 @@ You will need some fresh v8 Google JavaScript enging version installed. At this
103103
```
104104

105105

106-
### Installing from packages
106+
### Installing php-v8 from packages
107107

108108
- For Ubuntu there are [pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) PPA.
109109

110-
To install fresh `php7.0` do:
110+
To install fresh `php-v8`:
111111

112112
```
113113
$ sudo add-apt-repository -y ppa:pinepain/php-v8
@@ -122,7 +122,7 @@ You will need some fresh v8 Google JavaScript enging version installed. At this
122122
$ brew install https://raw.githubusercontent.com/pinepain/php-v8/master/scripts/homebrew/php70-v8.rb
123123
```
124124

125-
### Building from sources
125+
### Building php-v8 from sources
126126

127127
```
128128
git clone https://github.com/pinepain/php-v8.git
@@ -152,5 +152,7 @@ Copyright (c) 2015-2016 Bogdan Padalko &lt;[email protected]&gt;
152152
[php-v8](https://github.com/pinepain/php-v8) PHP extension is licensed under the [MIT license](http://opensource.org/licenses/MIT).
153153

154154

155+
[v8-hello-world]: https://chromium.googlesource.com/v8/v8/+/master/samples/hello-world.cc
156+
[v8-intro]: https://developers.google.com/v8/intro
155157
[php70-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php70-v8.rb
156158
[php71-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php71-v8.rb

0 commit comments

Comments
 (0)