Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Rename V8\Exception class and it methods #33

Closed
pinepain opened this issue Sep 1, 2017 · 0 comments
Closed

Rename V8\Exception class and it methods #33

pinepain opened this issue Sep 1, 2017 · 0 comments
Assignees
@pinepain
Labels
bc-breaking enhancement
Milestone
0.2.0

Comments

@pinepain
Copy link
Member

pinepain commented Sep 1, 2017 •
edited
Loading

This would be API breaking change.

Current naming creates ambiguity with PHP exceptions and class static methods should be named more verbose.
@pinepain pinepain closed this as completed Sep 1, 2017
@pinepain pinepain reopened this Sep 1, 2017
@pinepain pinepain changed the title Rename constants to match PSR-2 convention Rename V8\Exception class and it methods to avoid ambiguity with PHP exceptions Sep 1, 2017
@pinepain pinepain changed the title Rename V8\Exception class and it methods to avoid ambiguity with PHP exceptions Rename V8\Exception class and it methods Sep 1, 2017
@pinepain pinepain added this to the 0.2.0 milestone Sep 1, 2017
@pinepain pinepain self-assigned this Sep 1, 2017
pinepain added a commit that referenced this issue Sep 1, 2017
@pinepain
Rename V8\Exception class and it methods, closes #33
934a236
pinepain added a commit that referenced this issue Sep 2, 2017
@pinepain
Rename V8\Exception class and it methods, closes #33
6f609db
pinepain added a commit that referenced this issue Sep 2, 2017
@pinepain
Rename V8\Exception class and it methods, closes #33
5aa2a29
pinepain added a commit that referenced this issue Sep 2, 2017
@pinepain
Rename V8\Exception class and it methods, closes #33
fc52d4d
@pinepain pinepain mentioned this issue Sep 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pinepain pinepain

Labels
bc-breaking enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@pinepain