Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Add Data typehing to Template::set() for $value parameter #36

Closed
pinepain opened this issue Sep 1, 2017 · 0 comments
Closed

Add Data typehing to Template::set() for $value parameter #36

pinepain opened this issue Sep 1, 2017 · 0 comments
Assignees
Milestone

Comments

@pinepain
Copy link
Member

pinepain commented Sep 1, 2017

This changes is BC compatible.

Template::set() $value could be one of PrimitiveValue or Template instance. Both of them extends meta-class Data. While there is already an internals type check for that, restricting $value to accept only Data instances will improve overall method interface and allow users to catch type errors early.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant