Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Refactor ScriptOriginOptions to use bit field #42

Closed
pinepain opened this issue Sep 2, 2017 · 0 comments
Closed

Refactor ScriptOriginOptions to use bit field #42

pinepain opened this issue Sep 2, 2017 · 0 comments
Assignees
@pinepain
Labels
bc-breaking enhancement
Milestone
0.2.0

Comments

@pinepain
Copy link
Member

pinepain commented Sep 2, 2017

It's annoying to have so many boolean args for such primitive thing. As we are walking away to be 1 to 1 binding to V8 C++ API (it's a matter of common sense if you would ask), we don't need this anymore.

ScriptOrigin and ScriptOriginOptions are affected.
@pinepain pinepain added this to the 0.2.0 milestone Sep 2, 2017
@pinepain pinepain changed the title Refactor ScriptOriginOptions to be bitwise field Refactor ScriptOriginOptions to be bit field Sep 4, 2017
@pinepain pinepain self-assigned this Sep 6, 2017
@pinepain pinepain changed the title Refactor ScriptOriginOptions to be bit field Refactor ScriptOriginOptions to use bit field Sep 6, 2017
@pinepain pinepain mentioned this issue Sep 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pinepain pinepain

Labels
bc-breaking enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@pinepain