Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Add missed JSON class support #56

Closed
pinepain opened this issue Sep 4, 2017 · 1 comment
Closed

Add missed JSON class support #56

pinepain opened this issue Sep 4, 2017 · 1 comment
Assignees
Milestone

Comments

@pinepain
Copy link
Member

pinepain commented Sep 4, 2017

While we have all that in PHP, it might come in handy under certain circumstances to use V8's JSON::stringify() and JSON::parse().

For those who want to contribute: this task is easy to pick - just draw inspiration from existent php-v8 code style. V8's JSON class is very simple and it has just two static methods, which should be also static in PHP: https://github.com/v8/v8/blob/6441d234c4148e8e34a623ba3e5861a451737ffc/include/v8.h#L1799-L1829

@pinepain pinepain added this to the 0.2.0 milestone Sep 7, 2017
@pinepain
Copy link
Member Author

As of 6.3.117, v8 makes v8::JSON::Stringify take Local<Value> instead of Local<Object> (v8/v8@6716a7f#diff-3dd7a0f46b1e5c1cc67921449e7180ac)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant