Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Remove redundant Message::is* methods #61

Closed
pinepain opened this issue Sep 6, 2017 · 0 comments
Closed

Remove redundant Message::is* methods #61

pinepain opened this issue Sep 6, 2017 · 0 comments
Assignees
@pinepain
Labels
bc-breaking enhancement
Milestone
0.2.0

Comments

@pinepain
Copy link
Member

pinepain commented Sep 6, 2017 •
edited
Loading

Message::isSharedCrossOrigin() and Message::isOpaque() are effectively duplicating methods from ScriptOriginOptions, which could be retrieved as Message::getScriptOrigin()->options().
As we don't strictly follow V8 C++API, we don't need them.
@pinepain pinepain added this to the 0.2.0 milestone Sep 6, 2017
@pinepain pinepain self-assigned this Sep 6, 2017
@pinepain pinepain changed the title Remove redundant ScriptOrigin is* methods Remove redundant Message::is* methods Sep 6, 2017
@pinepain pinepain mentioned this issue Sep 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pinepain pinepain

Labels
bc-breaking enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@pinepain