Skip to content

Commit 4c026f3

Browse files
committed
use isolate version of v8::ScriptOrigin
1 parent acd9431 commit 4c026f3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

v8js_class.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ static void v8js_compile_script(zval *this_ptr, const zend_string *str, const ze
636636
v8::Local<v8::String> sname = identifier
637637
? V8JS_ZSTR(identifier)
638638
: V8JS_SYM("V8Js::compileString()");
639-
v8::ScriptOrigin origin(sname);
639+
v8::ScriptOrigin origin(isolate, sname);
640640

641641
if (ZSTR_LEN(str) > std::numeric_limits<int>::max()) {
642642
zend_throw_exception(php_ce_v8js_exception,

v8js_methods.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ V8JS_METHOD(require)
516516

517517
// Set script identifier
518518
v8::Local<v8::String> sname = V8JS_STR(normalised_module_id);
519-
v8::ScriptOrigin origin(sname);
519+
v8::ScriptOrigin origin(isolate, sname);
520520

521521
if (Z_STRLEN(module_code) > std::numeric_limits<int>::max()) {
522522
zend_throw_exception(php_ce_v8js_exception,

0 commit comments

Comments
 (0)