Skip to content

Commit 51d34e0

Browse files
committed
Fix for V8 timezone notification
1 parent 3628688 commit 51d34e0

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

tests/timezones.phpt

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
--TEST--
22
Test V8::executeString() : Check timezone handling
33
--SKIPIF--
4-
SKIP test currently broken, see #378
5-
64
<?php
75
if(strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
86
die('SKIP TZ not handled by v8 on Windows');
@@ -39,7 +37,7 @@ try {
3937
?>
4038
===EOF===
4139
--EXPECT--
42-
Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
43-
Thu Mar 20 2014 05:03:24 GMT-0400 (EDT)
44-
Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
45-
===EOF===
40+
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
41+
Thu Mar 20 2014 05:03:24 GMT-0400 (Eastern Daylight Time)
42+
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
43+
===EOF===

v8js_v8.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ void v8js_v8_call(v8js_ctx *c, zval **return_value,
148148
c->tz = strdup(tz);
149149
}
150150
else if (strcmp(c->tz, tz) != 0) {
151-
c->isolate->DateTimeConfigurationChangeNotification();
151+
c->isolate->DateTimeConfigurationChangeNotification(v8::Isolate::TimeZoneDetection::kRedetect);
152152

153153
free(c->tz);
154154
c->tz = strdup(tz);

0 commit comments

Comments
 (0)