Skip to content

Commit 6b7ab04

Browse files
committed
Mention v8js.icudtl_dat_path in README files
1 parent 4d2118f commit 6b7ab04

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

README.Linux.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ ninja -C out.gn/x64.release/
6262
6363
# Install to /opt/v8/
6464
sudo mkdir -p /opt/v8/{lib,include}
65-
sudo cp out.gn/x64.release/lib*.so out.gn/x64.release/*_blob.bin /opt/v8/lib/
65+
sudo cp out.gn/x64.release/lib*.so out.gn/x64.release/*_blob.bin \
66+
out.gn/x64.release/icudtl.dat /opt/v8/lib/
6667
sudo cp -R include/* /opt/v8/include/
6768
```
6869

@@ -137,3 +138,9 @@ sudo make install
137138
```
138139

139140
Then add `extension=v8js.so` to your php.ini file. If you have a separate configuration for CLI, add it there also.
141+
142+
V8Js' build system assumes that the `icudtl.dat` file is located next to the `libv8.so`
143+
library file and compiles the path into the library itself. If for whatever reason the
144+
`icudtl.dat` file is stored at a different place during runtime, you need to set the
145+
php.ini variable `v8js.icudtl_dat_path` to point to the file. Otherwise locale-aware
146+
features of V8 will not work as expected.

README.MacOS.md

+6
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,9 @@ make
8080
make test
8181
make install
8282
```
83+
84+
V8Js' build system assumes that the `icudtl.dat` file is located next to the `libv8.dylib`
85+
library file and compiles the path into the library itself. If for whatever reason the
86+
`icudtl.dat` file is stored at a different place during runtime, you need to set the
87+
php.ini variable `v8js.icudtl_dat_path` to point to the file. Otherwise locale-aware
88+
features of V8 will not work as expected.

README.Win32.md

+5
Original file line numberDiff line numberDiff line change
@@ -168,3 +168,8 @@ Release_TS\php.exe -d extension=php_v8js.dll -d extension_dir=Release_TS\
168168
```
169169

170170
Alternatively copy all stuff to c:\php\ (including the DLL files from v8 build).
171+
172+
V8 library itself needs to load the `icudtl.dat` file at runtime. Make sure php.ini
173+
variable `v8js.icudtl_dat_path` points to this file; or as an alternative set
174+
`PHP_V8_EXEC_PATH` in config.w32 to point to the directory where the dll and data file
175+
are located.

0 commit comments

Comments
 (0)