Skip to content

Commit 712f541

Browse files
committed
Merge branch 'php7' of github.com:phpv8/v8js into php8
2 parents 4327b4a + 0754d73 commit 712f541

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Minimum requirements
2121
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
2222
V8 implements ECMAScript as specified in ECMA-262, 5th edition.
2323

24-
This extension requires V8 7.5 or higher.
24+
This extension requires V8 9.0 or higher.
2525

2626
V8 releases are published rather quickly and the V8 team usually provides security support
2727
for the version line shipped with the Chrome browser (stable channel) and newer (only).

config.m4

+2-2
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ int main ()
140140
set $ac_cv_v8_version
141141
IFS=$ac_IFS
142142
V8_API_VERSION=`expr [$]1 \* 1000000 + [$]2 \* 1000 + [$]3`
143-
if test "$V8_API_VERSION" -lt 7005000 ; then
144-
AC_MSG_ERROR([libv8 must be version 7.5 or greater])
143+
if test "$V8_API_VERSION" -lt 9000000 ; then
144+
AC_MSG_ERROR([libv8 must be version 9.0 or greater])
145145
fi
146146
AC_DEFINE_UNQUOTED([PHP_V8_API_VERSION], $V8_API_VERSION, [ ])
147147
AC_DEFINE_UNQUOTED([PHP_V8_VERSION], "$ac_cv_v8_version", [ ])

v8js_class.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ static void v8js_compile_script(zval *this_ptr, const zend_string *str, const ze
636636
v8::Local<v8::String> sname = identifier
637637
? V8JS_ZSTR(identifier)
638638
: V8JS_SYM("V8Js::compileString()");
639-
v8::ScriptOrigin origin(sname);
639+
v8::ScriptOrigin origin(isolate, sname);
640640

641641
if (ZSTR_LEN(str) > std::numeric_limits<int>::max()) {
642642
zend_throw_exception(php_ce_v8js_exception,

v8js_methods.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ V8JS_METHOD(require)
516516

517517
// Set script identifier
518518
v8::Local<v8::String> sname = V8JS_STR(normalised_module_id);
519-
v8::ScriptOrigin origin(sname);
519+
v8::ScriptOrigin origin(isolate, sname);
520520

521521
if (Z_STRLEN(module_code) > std::numeric_limits<int>::max()) {
522522
zend_throw_exception(php_ce_v8js_exception,

0 commit comments

Comments
 (0)