Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Particle::normal field #49

Open
kolayne opened this issue Jan 31, 2021 · 0 comments
Open

Remove the Particle::normal field #49

kolayne opened this issue Jan 31, 2021 · 0 comments

Comments

@kolayne
Copy link
Member

kolayne commented Jan 31, 2021

The normal field is currently a normal of the face the particle is located at. But this is a duplicated information (the normal is stored in the Face object already), neither normal is a property of a particle in any way. So, the field must be removed, the some_particle->map_node->get_face()->get_normal() expression should be used to retrieve a normal given a particle

/// Normal to the current face
SpacePoint normal;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant