trying to fix 'Not checking non-flow files' issue

Author: pichillilorenzo

README.md

@@ -69,7 +69,7 @@ Manually:
 
 If the plugin gives to you message errors like `Error during installation: "node.js" seems not installed on your system...` but instead you have installed node.js and npm (for example using [nvm](https://github.com/creationix/nvm)), then you could try to set your custom path in the [Global settings](https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Global-settings) of the plugin and then restart Sublime Text.
 
-If this not works too, then you could try to add the custom path that contains binaries of node.js and npm in the **`PATH`** key-value on the same JavaScript Enhancements settings file. This variable will be **appended** to the **$PATH** environment variable, so you could use the same syntax in it. After that you need to restart Sublime Text. Example of a global setting for `Linux` that uses `nvm`:
+If this doesn't work too, then you could try to add the custom path that contains binaries of node.js and npm in the **`PATH`** key-value on the same JavaScript Enhancements settings file. This variable will be **appended** to the **$PATH** environment variable, so you could use the same syntax in it. After this you need to restart Sublime Text. Example of a global setting for `Linux` that uses `nvm`:
 
 ```
 {

_generated_2018_01_03_at_03_39_39.py renamed to _generated_2018_01_03_at_13_27_16.py

@@ -212,7 +212,16 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
 
       args = ( shlex.quote(self.node_js_path)+" " if use_node else "") +shlex.quote(os.path.join((bin_path or NODE_MODULES_BIN_PATH), command))+" "+command_args+(" < "+shlex.quote(fp.name) if fp and not use_only_filename_view_flow else "")
 
-      #print(args)
+    #print(args)
+      
+    old_env = os.environ.copy()
+
+    new_env = old_env.copy()
+    new_env["PATH"] = new_env["PATH"] + javascriptCompletions.get("PATH")
+
+    # update the PATH environment variable
+    os.environ.update(new_env)
+      
     try:
       output = None
       result = None
@@ -224,7 +233,10 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
       output = subprocess.check_output(
           args, shell=True, stderr=subprocess.STDOUT
       )
-      
+
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       if chdir:
         os.chdir(owd)
 
@@ -266,7 +278,11 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
         fp.close()
       return [True, result]
     except subprocess.CalledProcessError as e:
-      #print(traceback.format_exc())
+      print(traceback.format_exc())
+      
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       try:
         result = json.loads(output.decode("utf-8", "ignore")) if is_output_json else output.decode("utf-8", "ignore")
         if use_fp_temp :
@@ -279,6 +295,10 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
 
         return [False, None]
     except:
+
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       print(traceback.format_exc())
       if use_fp_temp :
         fp.close()
@@ -1226,14 +1246,15 @@ def init(self):
     node_modules_path = os.path.join(PACKAGE_PATH, "node_modules")
     npm = NPM()
     if not os.path.exists(node_modules_path):
+      sublime.active_window().status_message("JavaScript Enhancements - installing npm dependencies...")
       result = npm.install_all()
       if result[0]: 
         sublime.active_window().status_message("JavaScript Enhancements - npm dependencies installed correctly.")
       else:
         print(result)
         if os.path.exists(node_modules_path):
           shutil.rmtree(node_modules_path)
-        sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.")
+        sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in a way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.")
     # else:
     #   result = npm.update_all()
     #   if not result[0]: 
@@ -4867,10 +4888,12 @@ def start():
   global mainPlugin
 
   if sublime.platform() == 'windows':
+    print(sublime.platform())
     sublime.error_message("Windows is not supported by this plugin for now.")
     return
 
   if platform.architecture()[0] != "64bit":
+    print(platform.architecture())
     sublime.error_message("Your architecture is not supported by this plugin. This plugin supports only 64bit architectures.")
     return
 

changelog/0.1.12.txt

@@ -0,0 +1,79 @@
+v0.1.12
+
+## Fixes
+
+- Trying to fix "Not checking non-flow files" #7
+
+
+=================================================================
+** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
+=================================================================
+
+If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
+
+** USAGE **
+===========
+
+See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
+
+
+** WHAT IS THIS? **
+===================
+
+This plugin uses Flow (javascript static type checker from Facebook) under the hood.
+
+It offers better javascript autocomplete and a lot of features about creating, 
+developing and managing javascript projects, such as:
+
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 projects (same as Cordova projects!)
+- Angular v1 and v2 projects
+- React projects
+- Express projects
+- Yeoman generators
+- Local bookmarks project
+- JavaScript real-time errors
+- etc.
+
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
+
+It turns Sublime Text into a JavaScript IDE like!
+
+This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
+
+** NOTE **
+If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
+
+** OS SUPPORTED NOW **
+======================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+
+❗❗ Dependencies ❗❗
+=======================
+
+In order to work properly, this plugin has some dependencies:
+
+👉 Sublime Text 3 (build 3124 or newer)
+👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
+👉 TerminalView sublime text plugin (https://github.com/Wramberg/TerminalView)
+
+Not required, but useful for typescript files (Flow wont work on this type of files):
+
+👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin) 
+
+** Flow Requirements **
+=======================
+
+It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
+
+👉 Mac OS X
+👉 Linux (64-bit)
+👉 Windows (64-bit)
+
+Email me for any questions or doubts about this new project on: [email protected]
+
+Thanks for your support! 😄😄
+
+MIT License

helper/node/main.py

@@ -86,7 +86,16 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
 
       args = ( shlex.quote(self.node_js_path)+" " if use_node else "") +shlex.quote(os.path.join((bin_path or NODE_MODULES_BIN_PATH), command))+" "+command_args+(" < "+shlex.quote(fp.name) if fp and not use_only_filename_view_flow else "")
 
-      #print(args)
+    #print(args)
+      
+    old_env = os.environ.copy()
+
+    new_env = old_env.copy()
+    new_env["PATH"] = new_env["PATH"] + javascriptCompletions.get("PATH")
+
+    # update the PATH environment variable
+    os.environ.update(new_env)
+      
     try:
       output = None
       result = None
@@ -98,7 +107,10 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
       output = subprocess.check_output(
           args, shell=True, stderr=subprocess.STDOUT
       )
-      
+
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       if chdir:
         os.chdir(owd)
 
@@ -140,7 +152,11 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
         fp.close()
       return [True, result]
     except subprocess.CalledProcessError as e:
-      #print(traceback.format_exc())
+      print(traceback.format_exc())
+      
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       try:
         result = json.loads(output.decode("utf-8", "ignore")) if is_output_json else output.decode("utf-8", "ignore")
         if use_fp_temp :
@@ -153,6 +169,10 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
 
         return [False, None]
     except:
+
+      # reset the PATH environment variable
+      os.environ.update(old_env)
+
       print(traceback.format_exc())
       if use_fp_temp :
         fp.close()

make/_init.py

@@ -71,14 +71,15 @@ def init(self):
     node_modules_path = os.path.join(PACKAGE_PATH, "node_modules")
     npm = NPM()
     if not os.path.exists(node_modules_path):
+      sublime.active_window().status_message("JavaScript Enhancements - installing npm dependencies...")
       result = npm.install_all()
       if result[0]: 
         sublime.active_window().status_message("JavaScript Enhancements - npm dependencies installed correctly.")
       else:
         print(result)
         if os.path.exists(node_modules_path):
           shutil.rmtree(node_modules_path)
-        sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.")
+        sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in a way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.")
     # else:
     #   result = npm.update_all()
     #   if not result[0]: 
@@ -104,10 +105,12 @@ def start():
   global mainPlugin
 
   if sublime.platform() == 'windows':
+    print(sublime.platform())
     sublime.error_message("Windows is not supported by this plugin for now.")
     return
 
   if platform.architecture()[0] != "64bit":
+    print(platform.architecture())
     sublime.error_message("Your architecture is not supported by this plugin. This plugin supports only 64bit architectures.")
     return
 

messages.json

@@ -3,5 +3,6 @@
   "0.1.0": "changelog/0.1.0.txt",
   "0.1.01": "changelog/0.1.01.txt",
   "0.1.10": "changelog/0.1.10.txt",
-  "0.1.11": "changelog/0.1.11.txt"
+  "0.1.11": "changelog/0.1.11.txt",
+  "0.1.12": "changelog/0.1.12.txt"
 }