fix #21, fix #22, try to manage #20

Author: pichillilorenzo

JavaScript Enhancements.sublime-settings

@@ -1,15 +1,18 @@
 {
-  "enable_can_i_use_menu_option": true,
   "PATH": "",
   "node_js_custom_path": "node",
   "npm_custom_path": "npm",
   "yarn_custom_path": "yarn",
+
   "cordova_custom_path": "cordova",
   "ionicv1_custom_path": "ionic",
   "ionicv2_custom_path": "ionic",
   "angularv1_custom_path": "yo",
   "angularv2_custom_path": "ng",
   "react_custom_path": "create-react-app",
   "express_custom_path": "express",
-  "yeoman_custom_path": "yo"
+  "yeoman_custom_path": "yo",
+
+  "enable_can_i_use_menu_option": true,
+  "enable_unused_variables_feature": true
 }

_generated_2018_01_23_at_00_15_41.py renamed to _generated_2018_01_23_at_15_18_32.py

@@ -3,7 +3,7 @@
 from shutil import copyfile
 from threading import Timer
 
-PLUGIN_VERSION = "0.13.13"
+PLUGIN_VERSION = "0.13.14"
 
 PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
 PACKAGE_NAME = os.path.basename(PACKAGE_PATH)
@@ -243,7 +243,7 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
       output = subprocess.check_output(
           args, shell=True, stderr=subprocess.STDOUT, timeout=10
       )
-
+      
       if sublime.platform() == "windows" and use_fp_temp: 
         os.remove(fp.name)
 
@@ -5469,9 +5469,14 @@ def on_modified_async(self):
     super(unused_variablesViewEventListener, self).on_modified_async()
 
   def on_selection_modified_async(self):
+
     view = self.view
 
-    if view.find_by_selector('source.js.embedded.html'):
+    if not javascriptCompletions.get("enable_unused_variables_feature"):
+      view.erase_status("unused_variables")
+      view.erase_regions("unused_variables")
+      return 
+    elif view.find_by_selector('source.js.embedded.html'):
       pass
     elif not Util.selection_in_js_scope(view):
       view.erase_status("unused_variables")
@@ -5495,7 +5500,11 @@ def on_modified_async_with_thread(self, recheck=True):
 
     view = self.view
 
-    if view.find_by_selector('source.js.embedded.html'):
+    if not javascriptCompletions.get("enable_unused_variables_feature"):
+      view.erase_status("unused_variables")
+      view.erase_regions("unused_variables")
+      return 
+    elif view.find_by_selector('source.js.embedded.html'):
       pass
     elif not Util.selection_in_js_scope(view):
       view.erase_status("unused_variables")
@@ -5594,7 +5603,7 @@ def on_modified_async_with_thread(self, recheck=True):
 
             repetitions[variableName] = [variableRegion]
 
-          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression", "JSXIdentifier", "ExportDefaultDeclaration"], body)
+          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression", "JSXIdentifier", "ExportDefaultDeclaration", "JSXExpressionContainer", "NewExpression", "ReturnStatement"], body)
           for item in items:
 
             if "exportKind" in item and "declaration" in item and isinstance(item["declaration"],dict) and "name" in item["declaration"] and item["declaration"]["type"] == "Identifier":
@@ -5613,6 +5622,10 @@ def on_modified_async_with_thread(self, recheck=True):
                 for argument in item["arguments"]:
                   if isinstance(argument,dict) and "name" in argument and argument["type"] == "Identifier":
                     items += [argument]
+                  elif "expressions" in argument and argument["expressions"]:
+                    for expression in argument["expressions"]:
+                      if isinstance(expression,dict) and "name" in expression and expression["type"] == "Identifier":
+                        items += [expression]
 
               item = item["callee"]
 

changelog/0.13.14.txt

@@ -0,0 +1,96 @@
+v0.13.14
+
+## Fixes
+
+- Fixed "Unused variable shows up in React project" #20
+- Fixed Unused variable is shown when it's used with "new" #21
+- Fixed Unused variable is shown when it's used with "return" or in a template string #22
+
+## Improvements
+
+- Added "enable_unused_variables_feature" option to the plugin settings.
+
+
+
+=================================================================
+** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
+=================================================================
+
+If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
+
+** USAGE **
+===========
+
+See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
+
+
+** WHAT IS THIS? **
+===================
+
+This plugin uses Flow (javascript static type checker from Facebook) under the hood.
+
+It offers better javascript autocomplete and a lot of features about creating, 
+developing and managing javascript projects, such as:
+
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 projects (same as Cordova projects!)
+- Angular v1 and v2 projects
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also NativeScript support)
+- Express projects (only about the creation at this moment)
+- Yeoman generators
+- Local bookmarks project
+- JavaScript real-time errors
+- etc.
+
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
+
+It turns Sublime Text into a JavaScript IDE like!
+
+This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
+
+** NOTE **
+If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
+
+** OS SUPPORTED NOW **
+======================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+
+❗❗ Dependencies ❗❗
+=======================
+
+In order to work properly, this plugin has some dependencies:
+
+👉 Sublime Text 3 (build 3124 or newer)
+👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
+👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
+
+Not required, but useful for typescript files (Flow wont work on this type of files):
+
+👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin) 
+
+** Flow Requirements **
+=======================
+
+It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
+
+👉 Mac OS X
+👉 Linux (64-bit)
+👉 Windows (64-bit)
+
+Email me for any questions or doubts about this new project on: [email protected]
+
+** Donation **
+==============
+
+If this project help you reduce time to develop and also you like it, please support it with a donation 😄👍. Thanks!
+
+Open Collective: https://opencollective.com/javascriptenhancements/donate
+PayPal: https://www.paypal.me/LorenzoPichilli
+
+Thanks anyway for your support! 😄😄
+
+MIT License

helper/can_i_use/can_i_use_data.json

@@ -112,7 +112,7 @@ def execute_check_output(self, command, command_args, is_from_bin=False, use_fp_
       output = subprocess.check_output(
           args, shell=True, stderr=subprocess.STDOUT, timeout=10
       )
-
+      
       if sublime.platform() == "windows" and use_fp_temp: 
         os.remove(fp.name)
 

helper/node/main.py

@@ -17,9 +17,14 @@ def on_modified_async(self):
     super(unused_variablesViewEventListener, self).on_modified_async()
 
   def on_selection_modified_async(self):
+
     view = self.view
 
-    if view.find_by_selector('source.js.embedded.html'):
+    if not javascriptCompletions.get("enable_unused_variables_feature"):
+      view.erase_status("unused_variables")
+      view.erase_regions("unused_variables")
+      return 
+    elif view.find_by_selector('source.js.embedded.html'):
       pass
     elif not Util.selection_in_js_scope(view):
       view.erase_status("unused_variables")
@@ -43,7 +48,11 @@ def on_modified_async_with_thread(self, recheck=True):
 
     view = self.view
 
-    if view.find_by_selector('source.js.embedded.html'):
+    if not javascriptCompletions.get("enable_unused_variables_feature"):
+      view.erase_status("unused_variables")
+      view.erase_regions("unused_variables")
+      return 
+    elif view.find_by_selector('source.js.embedded.html'):
       pass
     elif not Util.selection_in_js_scope(view):
       view.erase_status("unused_variables")
@@ -142,7 +151,7 @@ def on_modified_async_with_thread(self, recheck=True):
 
             repetitions[variableName] = [variableRegion]
 
-          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression", "JSXIdentifier", "ExportDefaultDeclaration"], body)
+          items = Util.nested_lookup("type", ["VariableDeclarator", "MemberExpression", "CallExpression", "BinaryExpression", "ExpressionStatement", "Property", "ArrayExpression", "ObjectPattern", "AssignmentExpression", "IfStatement", "ForStatement", "WhileStatement", "ForInStatement", "ForOfStatement", "LogicalExpression", "UpdateExpression", "ArrowFunctionExpression", "ConditionalExpression", "JSXIdentifier", "ExportDefaultDeclaration", "JSXExpressionContainer", "NewExpression", "ReturnStatement"], body)
           for item in items:
 
             if "exportKind" in item and "declaration" in item and isinstance(item["declaration"],dict) and "name" in item["declaration"] and item["declaration"]["type"] == "Identifier":
@@ -161,6 +170,10 @@ def on_modified_async_with_thread(self, recheck=True):
                 for argument in item["arguments"]:
                   if isinstance(argument,dict) and "name" in argument and argument["type"] == "Identifier":
                     items += [argument]
+                  elif "expressions" in argument and argument["expressions"]:
+                    for expression in argument["expressions"]:
+                      if isinstance(expression,dict) and "name" in expression and expression["type"] == "Identifier":
+                        items += [expression]
 
               item = item["callee"]
 

helper/unused_variables_view_event_listener.py

@@ -3,7 +3,7 @@
 from shutil import copyfile
 from threading import Timer
 
-PLUGIN_VERSION = "0.13.13"
+PLUGIN_VERSION = "0.13.14"
 
 PACKAGE_PATH = os.path.abspath(os.path.dirname(__file__))
 PACKAGE_NAME = os.path.basename(PACKAGE_PATH)

make/_init.py

@@ -13,5 +13,6 @@
   "0.13.1": "changelog/0.13.1.txt",
   "0.13.11": "changelog/0.13.11.txt",
   "0.13.12": "changelog/0.13.12.txt",
-  "0.13.13": "changelog/0.13.13.txt"
+  "0.13.13": "changelog/0.13.13.txt",
+  "0.13.14": "changelog/0.13.14.txt"
 }