From c59051f353094db160cb26fef5828d844b34d1cd Mon Sep 17 00:00:00 2001
From: Eric Bower <me@erock.io>
Date: Thu, 12 Dec 2024 23:39:25 -0500
Subject: [PATCH] refactor(feeds): remove feeds after 3 failed attempts

We have a bunch of feeds in our system that are failing in a loop.
Previously we did not notify the user when there was a failure, we just
logged it internally.

With this change, we will prepend errors to the email message body.
Further, if the feeds errors and doesn't return any feed items, we
increment a counter.  3 failed attempts and we remove the post and
notify the user.
---
 db/db.go      |  1 +
 feeds/cron.go | 84 ++++++++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 74 insertions(+), 11 deletions(-)

diff --git a/db/db.go b/db/db.go
index d325e2b2..d6e20587 100644
--- a/db/db.go
+++ b/db/db.go
@@ -32,6 +32,7 @@ type User struct {
 type PostData struct {
 	ImgPath    string     `json:"img_path"`
 	LastDigest *time.Time `json:"last_digest"`
+	Attempts   int        `json:"attempts"`
 }
 
 // Make the Attrs struct implement the driver.Valuer interface. This method
diff --git a/feeds/cron.go b/feeds/cron.go
index fb41b576..b1b55708 100644
--- a/feeds/cron.go
+++ b/feeds/cron.go
@@ -175,25 +175,77 @@ func (f *Fetcher) RunPost(logger *slog.Logger, user *db.User, post *db.Post) err
 		urls = append(urls, url)
 	}
 
-	msgBody, err := f.FetchAll(logger, urls, parsed.InlineContent, user.Name, post)
+	now := time.Now().UTC()
+	if post.ExpiresAt == nil {
+		expiresAt := time.Now().AddDate(0, 6, 0)
+		post.ExpiresAt = &expiresAt
+	}
+	post.Data.LastDigest = &now
+	_, err = f.db.UpdatePost(post)
 	if err != nil {
 		return err
 	}
 
 	subject := fmt.Sprintf("%s feed digest", post.Title)
-	err = f.SendEmail(logger, user.Name, parsed.Email, subject, msgBody)
+
+	msgBody, err := f.FetchAll(logger, urls, parsed.InlineContent, user.Name, post)
 	if err != nil {
-		return err
+		errForUser := err
+
+		// we don't want to increment in this case
+		if errors.Is(errForUser, ErrNoRecentArticles) {
+			return nil
+		}
+
+		post.Data.Attempts += 1
+		logger.Error("could not fetch urls", "err", err, "attempts", post.Data.Attempts)
+
+		errBody := fmt.Sprintf(`There was an error attempting to fetch your feeds (%d) times.  After (3) attempts we remove the file from our system.  Please check all the URLs and re-upload.
+Also, we have centralized logs in our pico.sh TUI that will display realtime feed errors so you can debug.
+
+
+%s
+
+
+%s`, post.Data.Attempts, errForUser.Error(), post.Text)
+		err = f.SendEmail(
+			logger, user.Name,
+			parsed.Email,
+			subject,
+			&MsgBody{Html: strings.ReplaceAll(errBody, "\n", "<br />"), Text: errBody},
+		)
+		if err != nil {
+			return err
+		}
+
+		if post.Data.Attempts >= 3 {
+			err = f.db.RemovePosts([]string{post.ID})
+			if err != nil {
+				return err
+			}
+		} else {
+			_, err = f.db.UpdatePost(post)
+			if err != nil {
+				return err
+			}
+		}
+		return errForUser
+	} else {
+		post.Data.Attempts = 0
+		_, err := f.db.UpdatePost(post)
+		if err != nil {
+			return err
+		}
 	}
 
-	now := time.Now().UTC()
-	if post.ExpiresAt == nil {
-		expiresAt := time.Now().AddDate(0, 6, 0)
-		post.ExpiresAt = &expiresAt
+	if msgBody != nil {
+		err = f.SendEmail(logger, user.Name, parsed.Email, subject, msgBody)
+		if err != nil {
+			return err
+		}
 	}
-	post.Data.LastDigest = &now
-	_, err = f.db.UpdatePost(post)
-	return err
+
+	return nil
 }
 
 func (f *Fetcher) RunUser(user *db.User) error {
@@ -353,12 +405,14 @@ func (f *Fetcher) FetchAll(logger *slog.Logger, urls []string, inlineContent boo
 		return nil, err
 	}
 
+	var allErrors error
 	for _, url := range urls {
 		feedTmpl, err := f.Fetch(logger, fp, url, username, feedItems)
 		if err != nil {
 			if errors.Is(err, ErrNoRecentArticles) {
 				logger.Info("no recent articles", "err", err)
 			} else {
+				allErrors = errors.Join(allErrors, fmt.Errorf("%s: %w", url, err))
 				logger.Error("fetch error", "err", err)
 			}
 			continue
@@ -367,7 +421,10 @@ func (f *Fetcher) FetchAll(logger *slog.Logger, urls []string, inlineContent boo
 	}
 
 	if len(feeds.Feeds) == 0 {
-		return nil, fmt.Errorf("(%s) %w, skipping email", username, ErrNoRecentArticles)
+		if allErrors != nil {
+			return nil, allErrors
+		}
+		return nil, fmt.Errorf("%w, skipping email", ErrNoRecentArticles)
 	}
 
 	fdi := []*db.FeedItem{}
@@ -401,6 +458,11 @@ func (f *Fetcher) FetchAll(logger *slog.Logger, urls []string, inlineContent boo
 		return nil, err
 	}
 
+	if allErrors != nil {
+		text = fmt.Sprintf("> %s\n\n%s", allErrors, text)
+		html = fmt.Sprintf("<blockquote>%s</blockquote><br /><br/>%s", allErrors, html)
+	}
+
 	return &MsgBody{
 		Text: text,
 		Html: html,