Skip to content

Commit 1aab9f1

Browse files
committed
Actually yes, we need to handle empty in-view range..
1 parent 5c697de commit 1aab9f1

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

piker/ui/view_mode.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -668,18 +668,17 @@ def overlay_viewlists(
668668
f'yref@xref_pin: {yref}\n'
669669
)
670670

671-
# if we need to handle not-in-view cases?
672-
# mx_scalars = mx_viz.scalars_from_index(xref)
673-
# if mx_scalars is None:
674-
# continue
675-
671+
# XXX: we need to handle not-in-view cases?
672+
# still not sure why or when tf this happens..
673+
mx_scalars = mx_viz.scalars_from_index(xref)
674+
if mx_scalars is None:
675+
continue
676676
(
677677
i_start,
678678
y_ref_major,
679679
r_up_from_major_at_xref,
680680
r_down_from_major_at_xref,
681-
) = mx_viz.scalars_from_index(xref)
682-
# ) = mx_scalars
681+
) = mx_scalars
683682

684683
if debug_print:
685684
print(

0 commit comments

Comments
 (0)