Fixing bugs around NOTE_DIRECTORY having spaces

Author: paulbellamy

notes

@@ -2,15 +2,15 @@
 
 configured_dir=${NOTES_DIRECTORY%/} # Remove trailing slashes
 notes_dir="${configured_dir:-$HOME/notes}"
-escaped_notes_dir=$(printf $notes_dir | sed -e 's/[]\/$*.^|[]/\\&/g')
+escaped_notes_dir="$(printf "$notes_dir" | sed -e 's/[]\/$*.^|[]/\\&/g')"
 
 # If no $EDITOR, look for `editor` (symlink on debian/ubuntu/etc)
 if [ -z "$EDITOR" ] && type editor &>/dev/null; then
     EDITOR=editor
 fi
 
 without_notes_dir() {
-    cat | sed -e s/^$escaped_notes_dir//g | sed -E "s/^\/+//g" 
+    cat | sed -e "s/^$escaped_notes_dir//g" | sed -E "s/^\/+//g"
 }
 
 find_notes() {

test/test-find.bats

@@ -81,4 +81,14 @@ notes="./notes"
 
   assert_success
   assert_output "path with spaces/note.md"
-}
+}
+
+@test "Should find files inside notes directories with spaces" {
+  mkdir "$NOTES_DIRECTORY/path with spaces"
+  touch "$NOTES_DIRECTORY/path with spaces/note.md"
+
+  NOTES_DIRECTORY="$NOTES_DIRECTORY/path with spaces" run $notes find
+
+  assert_success
+  assert_output "note.md"
+}

test/test-new.bats

@@ -49,3 +49,10 @@ notes="./notes"
   assert_success
   assert_exists "$NOTES_DIRECTORY/subfolder with spaces/note.md"
 }
+
+@test "Should create notes within note directories with spaces" {
+  NOTES_DIRECTORY="$NOTES_DIRECTORY/notes with spaces" run $notes new "note"
+
+  assert_success
+  assert_exists "$NOTES_DIRECTORY/notes with spaces/note.md"
+}