Skip to content

Commit 173ac11

Browse files
committed
Properly activate virtualenv before running certain commands
1 parent 3a3cc12 commit 173ac11

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

Makefile

+8-11
Original file line numberDiff line numberDiff line change
@@ -40,46 +40,43 @@ setup: .env .venv requirements.txt.log requirements-mysql.txt.log requirements-p
4040

4141

4242
requirements.txt.log: requirements.txt
43-
@pip install -r requirements.txt | tee .requirements.txt.tmp.log
43+
@. .venv/bin/activate && pip install -r requirements.txt | tee .requirements.txt.tmp.log
4444
@mv .requirements.txt.tmp.log requirements.txt.log
4545

4646
requirements-mysql.txt.log: .env requirements-mysql.txt
47-
@(grep '^W2_DATABASE_ENGINE' .env | grep 'mysql' > /dev/null && pip install -r requirements-mysql.txt || echo "Not using MySQL") | tee .requirements-mysql.txt.tmp.log
47+
@. .venv/bin/activate && (grep '^W2_DATABASE_ENGINE' .env | grep 'mysql' > /dev/null && pip install -r requirements-mysql.txt || echo "Not using MySQL") | tee .requirements-mysql.txt.tmp.log
4848
@mv .requirements-mysql.txt.tmp.log requirements-mysql.txt.log
4949

5050
requirements-postgresql.txt.log: .env requirements-postgresql.txt
51-
@(grep '^W2_DATABASE_ENGINE' .env | grep 'postgresql' > /dev/null && pip install -r requirements-postgresql.txt || echo "Not using PostgreSQL") | tee .requirements-postgresql.txt.tmp.log
51+
@. .venv/bin/activate && (grep '^W2_DATABASE_ENGINE' .env | grep 'postgresql' > /dev/null && pip install -r requirements-postgresql.txt || echo "Not using PostgreSQL") | tee .requirements-postgresql.txt.tmp.log
5252
@mv .requirements-postgresql.txt.tmp.log requirements-postgresql.txt.log
5353

5454

5555
.PHONY: test
5656
test: setup ## Runs the unit tests
57-
@. .venv/bin/activate
58-
@./manage.py test
57+
@. .venv/bin/activate && ./manage.py test
5958

6059

6160
.PHONY: migrate
6261
migrate: setup ## Runs the migrate Django management command
63-
@. .venv/bin/activate
64-
@./manage.py migrate
62+
@. .venv/bin/activate && ./manage.py migrate
6563

6664

6765
.PHONY: load_fake_data
6866
load_fake_data: setup ## Loads up fake data using custom Django management command
69-
@. .venv/bin/activate
70-
@./manage.py load_fake_data --full --reset
67+
@. .venv/bin/activate && ./manage.py load_fake_data --full --reset
7168

7269
.PHONY: run
7370
run: setup ## Runs the Django development server
74-
@. .venv/bin/activate
75-
@./manage.py runserver
71+
@. .venv/bin/activate && ./manage.py runserver
7672

7773

7874
.PHONY: clean
7975
clean: ## Removes cached python files and virtualenv
8076
@echo "Deleting '__pycache__/' directories"
8177
@find . -name "__pycache__" -exec rm -rf {} \+
8278
@echo "Deleting the virtualenv ('./.venv/')"
79+
@rm requirements*.log
8380
@rm -rf .venv
8481

8582

0 commit comments

Comments
 (0)