Skip to content

Commit 50944ca

Browse files
committed
currentValue getter/setter
refactoring for better understanding documentation properties, variables, functions
1 parent 735b3fc commit 50944ca

File tree

5 files changed

+271
-145
lines changed

5 files changed

+271
-145
lines changed

public/globals.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ window.pkp = {
125125
'article.metadata': 'Metadata',
126126
'author.users.contributor.principalContact': 'Primary Contact',
127127
'author.users.contributor.setPrincipalContact': 'Set Primary Contact',
128+
'common.add': 'Add',
128129
'common.addCCBCC': 'Add CC/BCC',
129130
'common.assign': 'Assign',
130131
'common.attachFiles': 'Attach Files',
@@ -755,11 +756,11 @@ window.pkp = {
755756
'user.affiliations.translationDeleteActionLabel': 'Remove institution',
756757
'user.affiliations.translationActionsAriaLabel': 'Click to edit or delete',
757758
'user.affiliations.translationsAllAvailable': 'All translations available',
758-
'user.affiliations.translationsSomeAvailable': '{$translated} of {$total} languages completed',
759+
'user.affiliations.translationsSomeAvailable': '{$count} of {$total} languages completed',
759760
'user.affiliations.typeTranslationNameInLanguageLabel': 'Type the institute name in {$language}',
760761
'user.affiliations.translationNameInLanguage': 'Institute name in {$language}',
761762
'user.affiliations.deleteModal.title': 'Are you sure?',
762-
'user.affiliations.deleteModal.message': 'The institution <strong>{$institution}</strong> will be deleted.',
763+
'user.affiliations.deleteModal.message': 'The affiliation <strong>{$affiliation}</strong> will be deleted.',
763764
'user.affiliations.searchPhraseLabel': 'Type the institute name in {$language}',
764765
'user.affiliations.searchPhraseNothingFound': 'Your search phrase could not be found',
765766
'user.affiliations.primaryLocaleRequired': 'The primary language {$primaryLocale} is required',

src/components/Form/fields/FieldAffiliations.stories.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import FieldAffiliations from './FieldAffiliations.vue';
22
import FieldAffiliationsMock from '@/components/Form/mocks/field-affiliations';
3-
import {http, HttpResponse} from "msw";
3+
import {http, HttpResponse} from 'msw';
44

55
const args = {...FieldAffiliationsMock};
66

@@ -14,7 +14,7 @@ export default {
1414
http.get(
1515
'https://mock/index.php/publicknowledge/api/v1/rors/?searchPhrase=Simon+Fraser+University',
1616
async () => {
17-
return HttpResponse.json(args.apiResponse);
17+
return HttpResponse.json(args.searchResults);
1818
},
1919
),
2020
],
@@ -23,10 +23,10 @@ export default {
2323
render: (args) => ({
2424
components: {FieldAffiliations},
2525
setup() {
26-
return {args}
26+
return {args};
2727
},
2828
template: `
29-
<FieldAffiliations v-bind="args"/>`
29+
<FieldAffiliations v-bind="args"/>`,
3030
}),
3131
decorators: [
3232
() => ({

0 commit comments

Comments
 (0)