Revert logic related to release remote files (#46)

* Revert logic related to release remote files

* Fix

.github/workflows/plugin.yaml

@@ -28,8 +28,6 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
-      - name: Test
-        run: ./pleasew test //test/release_remote_files:please_pex_remote_hashes
       - name: Build
         run: ./pleasew build //package:release_files
       - name: Release

.plzconfig

@@ -24,8 +24,7 @@ DefaultValue = python3
 
 [PluginConfig "pex_tool"]
 ConfigKey = PexTool
-; Release artifact of //tools/please_pex:pex_main.
-DefaultValue = //tools:please_pex
+DefaultValue = //tools/please_pex:pex_main
 
 [PluginConfig "interpreter_options"]
 ConfigKey = InterpreterOptions

BUILD

@@ -1,5 +1,7 @@
 subinclude("//build_defs:version")
 
+version(name = "version")
+
 filegroup(
     name = "pleasew",
     srcs = ["pleasew"],
@@ -8,5 +10,4 @@ filegroup(
     visibility = ["PUBLIC"],
 )
 
-version(name = "version")
 

build_defs/BUILD

@@ -21,10 +21,3 @@ filegroup(
     srcs = ["multiversion_wheel.build_defs"],
     visibility = ["//third_party/..."],
 )
-
-filegroup(
-    name = "release_file",
-    srcs = ["release_file.build_defs"],
-    visibility = ["//package/..."],
-)
-

package/BUILD

@@ -1,16 +1,22 @@
-export_file(
-    name = "files",
-    src = "files.build_defs",
-    visibility = ["PUBLIC"],
-)
+subinclude("//:version", "//build_defs:archs")
+
+release_files = {
+    "please_pex": "//tools/please_pex:pex_main",
+}
 
-subinclude(":files", "//build_defs:release_file", "//build_defs:archs")
+def release_file(name:str, file_target:str, arch:str):
+    return genrule(
+        name = f"{name}_{arch}",
+        srcs = [f"///{arch}" + canonicalise(file_target)],
+        outs = [f"{name}-{VERSION}-{arch}"],
+        cmd = "mv $SRC $OUT",
+    )
 
 filegroup(
     name = "release_files",
     srcs = [
         release_file(name, target, arch)
-        for name, target in RELEASE_FILES.items()
+        for name, target in release_files.items()
         for arch in SUPPORTED_ARCHS
     ],
     labels = ["hlink:plz-out/package"],

tools/BUILD

@@ -1,22 +1,3 @@
-subinclude("//:version")
-
-# This target is meant to be used as the default pex tool for this plugin. It relies on the released artifact which might
-# not exist yet and as such, the hash sums won't be available too. To solve this a test will be run to guarantee that the
-# hashes below will match the ones of the artifact once released.
-remote_file(
-    name = "please_pex",
-    url = f"https://github.com/please-build/python-rules/releases/download/v{VERSION}/please_pex-{VERSION}-{CONFIG.HOSTOS}_{CONFIG.HOSTARCH}",
-    hashes = [
-        "28abdae0d17ca666663563f9b874ddfae0c5209389271d933945003c0ce9d6ab",
-        "3c621e8ff11301b64c7a0ca84ba23161fd5c777e4df82034060925f5106ee317",
-        "917e6ff3591f6bca5cfc2a251f136c180d743856bee877dc18626cc135bbe7a0",
-        "9c20d867ec1a1fcea85481d4a29ec80f8af5923fc06c7ad0057105918ec3e236",
-        "ab3426a82ab4cb5c5b0a4979a4a3821eb10361726759e30ab5f2a1e7c09fc78e",
-    ],
-    binary = True,
-    visibility = ["PUBLIC"],
-)
-
 remote_file(
     name = "arcat",
     url = f"https://github.com/please-build/arcat/releases/download/v1.0.0/arcat-1.0.0-{CONFIG.HOSTOS}_{CONFIG.HOSTARCH}",

tools/please_pex/BUILD

@@ -8,7 +8,7 @@ go_binary(
         "//third_party/go:go-logging.v1",
         "//tools/please_pex/pex",
     ],
-    visibility = ["//package/..."],
+    visibility = ["PUBLIC"],
 )
 
 python_test(