Pull please_pex from releases page (#43)

* Pull please_pex from releases page

* New release

* Link filegroup instead of go_binary because all sources get linked for go_binary
Remove hash from pex_tool remote_file pending some work to internally verify hashes

Author: samwestmoreland

.plzconfig

@@ -21,7 +21,7 @@ DefaultValue = python3
 
 [PluginConfig "pex_tool"]
 ConfigKey = PexTool
-DefaultValue = //tools/please_pex
+DefaultValue = //tools:please_pex
 
 [PluginConfig "interpreter_options"]
 ConfigKey = InterpreterOptions

ChangeLog

@@ -1,3 +1,7 @@
+Version 0.4.1
+-------------
+    * Pull please_pex from release page as remote_file
+
 Version 0.4.0
 -------------
     * Add please_pex tool to releases page

VERSION

@@ -1 +1 @@
-0.4.0
+0.4.1

tools/BUILD

@@ -1,9 +1,11 @@
-# Once pex tool is on the plugin releases page we can download the binary with a remote_file here. Same with the whele_resolver
-
-# remote_file(
-#     name = "please_pex",
-#     url = "https://www.github.com/please-build/python_rules/...",
-# )
+remote_file(
+    name = "please_pex",
+    url = "https://github.com/please-build/python-rules/releases/download/v0.4.0/please_pex",
+    extract = False,
+    binary = True,
+    visibility = ["PUBLIC"],
+    out = "please_pex_tool",
+)
 
 # remote_file(
 #     name = "wheel_resolver",

tools/please_pex/BUILD

@@ -1,15 +1,20 @@
 subinclude("//build_defs:python")
 
-go_binary(
+filegroup(
     name = "please_pex",
+    srcs = [":pex_main"],
+    visibility = ["PUBLIC"],
+    labels = ["hlink:plz-out/package"],
+)
+
+go_binary(
+    name = "pex_main",
     srcs = ["pex_main.go"],
     deps = [
         "//third_party/go:cli-init",
         "//third_party/go:go-logging.v1",
         "//tools/please_pex/pex",
     ],
-    visibility = ["PUBLIC"],
-    labels = ["hlink:plz-out/package"],
 )
 
 python_test(