Skip to content

Commit bd2f6ce

Browse files
committed
Bug fix 6.14.1: Set default RX pullup once in ctor, prevents flipping of that state on begin().
1 parent 907db30 commit bd2f6ce

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

library.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "EspSoftwareSerial",
3-
"version": "6.14.0",
3+
"version": "6.14.1",
44
"description": "Implementation of the Arduino software serial for ESP8266/ESP32.",
55
"keywords": [
66
"serial", "io", "softwareserial"

library.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name=EspSoftwareSerial
2-
version=6.14.0
2+
version=6.14.1
33
author=Dirk Kaar, Peter Lerup
44
maintainer=Dirk Kaar <[email protected]>
55
sentence=Implementation of the Arduino software serial for ESP8266/ESP32.

src/SoftwareSerial.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,13 @@ constexpr uint8_t BYTE_ALL_BITS_SET = ~static_cast<uint8_t>(0);
3232

3333
SoftwareSerial::SoftwareSerial() {
3434
m_isrOverflow = false;
35+
m_rxGPIOPullupEnabled = true;
3536
}
3637

3738
SoftwareSerial::SoftwareSerial(int8_t rxPin, int8_t txPin, bool invert)
3839
{
3940
m_isrOverflow = false;
41+
m_rxGPIOPullupEnabled = true;
4042
m_rxPin = rxPin;
4143
m_txPin = txPin;
4244
m_invert = invert;
@@ -126,7 +128,6 @@ void SoftwareSerial::begin(uint32_t baud, SoftwareSerialConfig config,
126128
m_pduBits = m_dataBits + static_cast<bool>(m_parityMode) + m_stopBits;
127129
m_bitCycles = (ESP.getCpuFreqMHz() * 1000000UL + baud / 2) / baud;
128130
m_intTxEnabled = true;
129-
m_rxGPIOPullupEnabled = true;
130131
if (isValidRxGPIOpin(m_rxPin)) {
131132
m_buffer.reset(new circular_queue<uint8_t>((bufCapacity > 0) ? bufCapacity : 64));
132133
if (m_parityMode)

0 commit comments

Comments
 (0)