Bug fix 6.14.1: Set default RX pullup once in ctor, prevents flipping…

… of that state on begin().
plerup · Oct 30, 2021 · bd2f6ce · bd2f6ce
1 parent 907db30
commit bd2f6ce
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
     "name": "EspSoftwareSerial",
-    "version": "6.14.0",
+    "version": "6.14.1",
     "description": "Implementation of the Arduino software serial for ESP8266/ESP32.",
     "keywords": [
         "serial", "io", "softwareserial"

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=EspSoftwareSerial
-version=6.14.0
+version=6.14.1
 author=Dirk Kaar, Peter Lerup
 maintainer=Dirk Kaar <[email protected]>
 sentence=Implementation of the Arduino software serial for ESP8266/ESP32.

diff --git a/src/SoftwareSerial.cpp b/src/SoftwareSerial.cpp
@@ -32,11 +32,13 @@ constexpr uint8_t BYTE_ALL_BITS_SET = ~static_cast<uint8_t>(0);
 
 SoftwareSerial::SoftwareSerial() {
     m_isrOverflow = false;
+    m_rxGPIOPullupEnabled = true;
 }
 
 SoftwareSerial::SoftwareSerial(int8_t rxPin, int8_t txPin, bool invert)
 {
     m_isrOverflow = false;
+    m_rxGPIOPullupEnabled = true;
     m_rxPin = rxPin;
     m_txPin = txPin;
     m_invert = invert;
@@ -126,7 +128,6 @@ void SoftwareSerial::begin(uint32_t baud, SoftwareSerialConfig config,
     m_pduBits = m_dataBits + static_cast<bool>(m_parityMode) + m_stopBits;
     m_bitCycles = (ESP.getCpuFreqMHz() * 1000000UL + baud / 2) / baud;
     m_intTxEnabled = true;
-    m_rxGPIOPullupEnabled = true;
     if (isValidRxGPIOpin(m_rxPin)) {
         m_buffer.reset(new circular_queue<uint8_t>((bufCapacity > 0) ? bufCapacity : 64));
         if (m_parityMode)