Clean up builds for better support

WillsonHaw · WillsonHaw · commit a793b9bfe7b8 · 2025-04-07T14:37:21.000-07:00
diff --git a/.changeset/loose-carrots-marry.md b/.changeset/loose-carrots-marry.md
@@ -0,0 +1,17 @@
+---
+"@plexinc/react-native-lightning-components": minor
+"@plexinc/react-native-lightning-example": minor
+"@plexinc/react-lightning-components": minor
+"@plexinc/react-native-lightning": minor
+"@plexinc/react-lightning-plugin-css-transform": minor
+"@plexinc/react-lightning-example": minor
+"@plexinc/react-lightning-plugin-flexbox-lite": minor
+"@plexinc/react-lightning-plugin-reanimated": minor
+"@repo/typescript-config": minor
+"@plexinc/react-lightning": minor
+"@plexinc/react-lightning-plugin-flexbox": minor
+"@repo/rollup-config": minor
+"@plexinc/react-lightning-storybook": minor
+---
+
+Clean up build configs for better support
diff --git a/apps/react-lightning-example/tsconfig.json b/apps/react-lightning-example/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "@repo/typescript-config/react-library.json",
   "compilerOptions": {
     "outDir": "dist",
-    "types": ["vite/client"]
+    "types": ["node", "vite/client"]
   },
   "include": ["src"],
   "exclude": ["node_modules", "dist"]
diff --git a/apps/react-lightning-example/vite.config.mjs b/apps/react-lightning-example/vite.config.mjs
@@ -34,7 +34,9 @@ const config = {
     force: true,
   },
   define: {
-    __DEV__: JSON.stringify(process.env.NODE_ENV === 'development'),
+    'process.env': JSON.stringify({
+      NODE_ENV: process.env.NODE_ENV,
+    }),
   },
 };
 
diff --git a/apps/react-native-lightning-example/vite.config.mjs b/apps/react-native-lightning-example/vite.config.mjs
@@ -24,7 +24,6 @@ const config = defineConfig({
     'process.env': JSON.stringify({
       NODE_ENV: process.env.NODE_ENV,
     }),
-    __DEV__: JSON.stringify(process.env.NODE_ENV === 'development'),
   },
 });
 
diff --git a/apps/storybook/.storybook/main.ts b/apps/storybook/.storybook/main.ts
@@ -15,9 +15,11 @@ const config: StorybookConfig = {
     options: {},
   },
   viteFinal(config) {
-    config.define = {
-      __DEV__: JSON.stringify(process.env.NODE_ENV === 'development'),
-    };
+    // config.define = {
+    //   'process.env': JSON.stringify({
+    //     NODE_ENV: process.env.NODE_ENV,
+    //   }),
+    // };
 
     config.plugins = [
       reactNativeLightningPlugin(),
diff --git a/apps/storybook/tsconfig.json b/apps/storybook/tsconfig.json
@@ -2,7 +2,11 @@
   "extends": "@repo/typescript-config/react-library.json",
   "compilerOptions": {
     "outDir": "dist",
-    "types": ["vite/client", "@plexinc/react-lightning-plugin-flexbox/jsx"]
+    "types": [
+      "node",
+      "vite/client",
+      "@plexinc/react-lightning-plugin-flexbox/jsx"
+    ]
   },
   "include": ["src"],
   "exclude": ["node_modules", "dist"]
diff --git a/package.json b/package.json
@@ -33,6 +33,7 @@
     "@repo/typescript-config": "workspace:*",
     "@rollup/wasm-node": "4.34.8",
     "@swc/core": "1.10.17",
+    "@types/node": "22.13.4",
     "del-cli": "6.0.0",
     "depcheck": "1.4.7",
     "glob": "11.0.1",
diff --git a/packages/plugin-css-transform/rollup.config.mjs b/packages/plugin-css-transform/rollup.config.mjs
@@ -1,6 +1,3 @@
 import createRollupConfig from '@repo/rollup-config';
 
-export default createRollupConfig({
-  useClient: true,
-  external: [],
-});
+export default createRollupConfig();
diff --git a/packages/plugin-flexbox-lite/rollup.config.mjs b/packages/plugin-flexbox-lite/rollup.config.mjs
@@ -1,5 +1,3 @@
 import createRollupConfig from '@repo/rollup-config';
 
-export default createRollupConfig({
-  useClient: true,
-});
+export default createRollupConfig();
diff --git a/packages/plugin-flexbox/rollup.config.mjs b/packages/plugin-flexbox/rollup.config.mjs
@@ -1,6 +1,5 @@
 import createRollupConfig from '@repo/rollup-config';
 
 export default createRollupConfig({
-  useClient: true,
   external: ['yoga-layout/load'],
 });
diff --git a/packages/plugin-reanimated/rollup.config.mjs b/packages/plugin-reanimated/rollup.config.mjs
@@ -1,7 +1,6 @@
 import createRollupConfig from '@repo/rollup-config';
 
 export default createRollupConfig({
-  useClient: true,
   outputExports: 'named',
   external: [
     'react/jsx-runtime',
diff --git a/packages/react-lightning-components/rollup.config.mjs b/packages/react-lightning-components/rollup.config.mjs
@@ -8,26 +8,10 @@ const configs = exportFiles.map((file) => {
   const outputDir = dirname(file.replace('src/exports', ''));
 
   return createRollupConfig({
-    useClient: true,
     input: file,
-    output: [
-      {
-        dir: `./dist/esm${outputDir}`,
-        entryFileNames: '[name].mjs',
-        assetFileNames: ({ name }) => name?.replace(/^src\//, '') ?? '',
-        format: 'esm',
-        exports: 'auto',
-      },
-      {
-        dir: `./dist/cjs${outputDir}`,
-        entryFileNames: '[name].js',
-        assetFileNames: ({ name }) => name?.replace(/^src\//, '') ?? '',
-        format: 'cjs',
-        exports: 'auto',
-      },
-    ],
+    outputDir: (format) => `./dist/${format}${outputDir}`,
     external: ['@plexinc/react-lightning', 'react', 'react/jsx-runtime'],
   });
 });
 
-export default configs;
+export default configs.flat();
diff --git a/packages/react-lightning-components/tsconfig.json b/packages/react-lightning-components/tsconfig.json
@@ -4,7 +4,7 @@
     "rootDir": "src",
     "declaration": false,
     "declarationMap": false,
-    "types": ["@plexinc/react-lightning-plugin-flexbox/jsx"]
+    "types": ["node", "@plexinc/react-lightning-plugin-flexbox/jsx"]
   },
   "include": ["src", "../../types/*.d.ts"],
   "exclude": ["node_modules", "dist"]
diff --git a/packages/react-lightning/rollup.config.mjs b/packages/react-lightning/rollup.config.mjs
@@ -1,8 +1,6 @@
 import createRollupConfig from '@repo/rollup-config';
 
 export default createRollupConfig({
-  useClient: true,
-  createDevBuilds: true,
   external: [
     '@lightningjs/renderer',
     '@lightningjs/renderer/webgl',
diff --git a/packages/react-lightning/src/element/LightningViewElement.ts b/packages/react-lightning/src/element/LightningViewElement.ts
@@ -247,7 +247,7 @@ export class LightningViewElement<
 
     this.node = this._createNode(lngProps);
 
-    if (__DEV__) {
+    if (process.env.NODE_ENV !== 'production') {
       this.node.__reactNode = this;
       this.node.__reactFiber = fiber;
     }
diff --git a/packages/react-lightning/src/render/index.tsx b/packages/react-lightning/src/render/index.tsx
@@ -122,7 +122,7 @@ export async function createRoot(
     target,
   );
 
-  if (__DEV__) {
+  if (process.env.NODE_ENV !== 'production') {
     window.__LIGHTNINGJS_DEVTOOLS__ = {
       renderer,
       features: ['react-lightning'],
diff --git a/packages/react-native-lightning-components/rollup.config.mjs b/packages/react-native-lightning-components/rollup.config.mjs
@@ -8,24 +8,8 @@ const configs = exportFiles.map((file) => {
   const outputDir = dirname(file.replace('src/exports', ''));
 
   return createRollupConfig({
-    useClient: true,
     input: file,
-    output: [
-      {
-        dir: `./dist/esm${outputDir}`,
-        entryFileNames: '[name].mjs',
-        assetFileNames: ({ name }) => name?.replace(/^src\//, '') ?? '',
-        format: 'esm',
-        exports: 'auto',
-      },
-      {
-        dir: `./dist/cjs${outputDir}`,
-        entryFileNames: '[name].js',
-        assetFileNames: ({ name }) => name?.replace(/^src\//, '') ?? '',
-        format: 'cjs',
-        exports: 'auto',
-      },
-    ],
+    outputDir: (format) => `./dist/${format}${outputDir}`,
     external: [
       '@plexinc/react-lightning',
       '@plexinc/react-native-lightning',
@@ -38,4 +22,4 @@ const configs = exportFiles.map((file) => {
   });
 });
 
-export default configs;
+export default configs.flat();
diff --git a/packages/react-native-lightning-components/tsconfig.json b/packages/react-native-lightning-components/tsconfig.json
@@ -4,7 +4,7 @@
     "rootDir": "src",
     "declaration": false,
     "declarationMap": false,
-    "types": ["@plexinc/react-lightning-plugin-flexbox/jsx"]
+    "types": ["node", "@plexinc/react-lightning-plugin-flexbox/jsx"]
   },
   "include": ["src", "../../types/*.d.ts"],
   "exclude": ["node_modules", "dist"]
diff --git a/packages/react-native-lightning/rollup.config.mjs b/packages/react-native-lightning/rollup.config.mjs
@@ -1,8 +1,6 @@
 import createRollupConfig from '@repo/rollup-config';
 
 export default createRollupConfig({
-  useClient: true,
-  createDevBuilds: true,
   external: [
     'react/jsx-runtime',
     'react',
diff --git a/packages/react-native-lightning/src/types/custom.d.ts b/packages/react-native-lightning/src/types/custom.d.ts
@@ -1,6 +0,0 @@
-declare module '*.png' {
-  const path: string;
-  export default path;
-}
-
-type AddMissingProps<T, U> = Omit<U, keyof T> & T;
diff --git a/packages/rollup-config/index.js b/packages/rollup-config/index.js
diff --git a/packages/rollup-config/package.json b/packages/rollup-config/package.json
diff --git a/packages/typescript-config/base.json b/packages/typescript-config/base.json
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/templates/app-template/vite.config.ts b/templates/app-template/vite.config.ts
diff --git a/types/global.d.ts b/types/global.d.ts
