Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Containerfiles for Gradle 8.8 #127

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Conversation

jimmyliang-gov
Copy link
Contributor

Purpose

New Feature: Adding Containerfile for an image with Gradle build tool. This is primary used to support Scala apps that are built with Gradle. Version 8.8 of Gradle is used.

NOTE: This PR is to merge from a feature branch to the main branch within the ploigos/ploigos-containers project.

The previous PR (#123) was to pull from a fork into a feature branch due to nuances with the CI build that was failing.

Breaking?

No

Integration Testing

This Containerfile was built and tested within an OpenShift 4.12 environment. Below is snippet from the OpenShift build that installs Gradle.

--> 0a1b5a1399c
STEP 12/17: RUN wget -qLO /tmp/gradle.zip "https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip" &&     mkdir /opt/gradle &&     unzip -d /opt/gradle /tmp/gradle.zip &&     rm /tmp/gradle.zip &&     chown -R ${PLOIGOS_USER_UID}:${PLOIGOS_USER_GID} /opt/gradle &&     chmod -R ug+wx /opt/gradle
Archive:  /tmp/gradle.zip
   creating: /opt/gradle/gradle-8.8/
  <TRUNCATED FOR BREVITY>
--> 6cbd18a06ed
STEP 13/17: ENV PATH="${PATH}:/opt/gradle/gradle-${GRADLE_VERSION}/bin"
--> 0a5f6e32c9a

The ploigos-tool-gradle was then tested with modified PSR steps that calls the Gradle CLI.

Below is a snippet from the PSR step calling unit-tests:

    --------------------------------------------------------------------------------
                         Standard Out - unit-test (GradleTest)                      
    --------------------------------------------------------------------------------
        Run unit tests
        
        Welcome to Gradle 8.8!
        
        Here are the highlights of this release:
         - Running Gradle on Java 22
         - Configurable Gradle daemon JVM
         - Improved IDE performance for large projects
        
        For more details see https://docs.gradle.org/8.8/release-notes.html
        
        Starting a Gradle Daemon (subsequent builds will be faster)
        > Task :app:compileJava
        > Task :app:processResources
        > Task :app:classes
        > Task :app:compileTestJava
        > Task :app:processTestResources NO-SOURCE
        > Task :app:testClasses
        > Task :app:test
        
        Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
        
        You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
        
        For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
        
        BUILD SUCCESSFUL in 57s
        4 actionable tasks: 4 executed

@jimmyliang-gov jimmyliang-gov added the enhancement New feature or request label Jun 16, 2024
@jimmyliang-gov jimmyliang-gov self-assigned this Jun 16, 2024
@jimmyliang-gov jimmyliang-gov requested review from itewk and jthompkins and removed request for jthompkins June 16, 2024 15:35
@jimmyliang-gov
Copy link
Contributor Author

Hi @itewk - Can you help me figure out why the push for the new images isn't working? Does it have something to do with Quay and new images?

@itewk
Copy link
Contributor

itewk commented Jun 17, 2024

Hi @itewk - Can you help me figure out why the push for the new images isn't working? Does it have something to do with Quay and new images?

issue is that the repo has to exist in quay for it to push to. that has been done now. lets see if that resolves it.

@itewk
Copy link
Contributor

itewk commented Jun 17, 2024

ugg, forgot to give the robo account permissions. trying again.

@itewk itewk merged commit 9e6345b into main Jun 17, 2024
51 checks passed
@itewk itewk deleted the feature/ploigos-tool-gradle branch June 17, 2024 12:13
@itewk
Copy link
Contributor

itewk commented Jun 17, 2024

@jimmyliang-gov thanks for the contribution. sorry for the pain and delays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants