Restore the "Use external editor" permission

[ale-rt]

Given the temporary lack of webdav, the permission Use external editor was removed on Python 3:
cda90e8

Should we restore it now that webdav is back or should we move the code in some other place?

[ale-rt]

There is also some other code that depends on the external editor:
https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/tests/testExternalEditorEnabled.py

[mauritsvanrees]

If I remember correctly, the external editor needs ZServer, so it won't work on Plone 6.
But on 5.2 the permission could be restored yes.

[ale-rt]

I think it just depends on webdav, which is now provide by Zope itself.
I am actually working on restoring the external editor in Plone 5.2.2/Python 3 and I am at a good point.
I am using this branch: zopefoundation/Products.ExternalEditor#14

[ale-rt]

Just for a confirmation external editor works on 6.0.

Creating a new Plone site with this buildout:

[buildout]
extends = https://raw.githubusercontent.com/plone/buildout.coredev/6.0/buildout.cfg
parts =
    instance
auto-checkout += 
    Products.ExternalEditor
   
[instance]
eggs += 
    Products.ExternalEditor

[sources]
Products.ExternalEditor= git ${remotes:zope}/Products.ExternalEditor.git pushurl=${remotes:zope_push}/Products.ExternalEditor.git branch=python3

adding a file, calling as admin:

• http://localhost:8080/Plone/externalEdit_/myfile.odt.zem

and running zopeedit allows me to modify the file on Plone.

Of course a regular user will not have the proper permissions, which were removed by cda90e8.
I am unsure if they should be restored in Plone or added in collective.externaleditor or another package.

[mauritsvanrees]

Your buildout runs, and the instance starts, so that is good. I see external editor icons in the ZMI and can click on it and it starts opening a .zem file. But I cannot really test it, because the zopeedit program fails for me.

• The bin/zopeedit script created by your buildout is a console script from Products.ExternalEditor which tries to import Products.ExternalEditor.zopeedit, which fails because it was moved to a separate package ten years ago.
• collective.zopeedit fails on Python 3: Fails on Python 3 collective/collective.zopeedit#14
• collective.zopeedit fails on Python 2: No such file: VERSION.txt collective/collective.zopeedit#15

[ale-rt]

I forgot to mention that for zopeedit I am using this branch https://github.com/collective/collective.zopeedit/tree/wip with Python2.7.