Skip to content

Commit 7465b18

Browse files
authored
Apply suggestions from code review
1 parent 1aba357 commit 7465b18

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

docs/contributing/core/index.md

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,20 +248,29 @@ It takes 5-10 minutes to run the full unit test suite.
248248
If you run acceptance tests with the `--all` option, it will run tests in a real browser.
249249
This takes 30-40 minutes to run.
250250
This may repeatedly launch and close browser windows that gain focus, disrupting you from doing any other work.
251-
If this happens, you can use `headlesschrome` as testbrowser by setting an environment variable `export ROBOT_BROWSER="headlesschrome"` and again run `bin/test --all`.
251+
If this happens, you can use `headlesschrome` as the test browser.
252+
First set an environment variable.
252253

253-
Since we use [Playwright](https://playwright.dev/) for our robottests you have to install it first.
254-
`plone.app.robotframework` provides a script for that:
254+
```shell
255+
export ROBOT_BROWSER="headlesschrome"
256+
```
257+
258+
Then run all tests again.
259+
260+
```shell
261+
bin/test --all
262+
```
263+
264+
Plone uses [Playwright](https://playwright.dev/) to run robot tests.
265+
`plone.app.robotframework` provides a script to install Playwrite browsers.
255266

256267
```shell
257-
# Install playwright browsers
258268
./bin/rfbrowser init
259269
```
260270

261-
After the browser resources are downloaded and initalized you can run the tests.
271+
After the script downloads and initalizes browser resources, you can run the acceptance tests.
262272

263273
```shell
264-
# Run acceptance tests
265274
./bin/test --all
266275
```
267276

0 commit comments

Comments
 (0)