Merge pull request #210 from plotly/lint-all-the-files

Lint all the files

Author: etpinard

.github/labeler.yml

@@ -14,8 +14,3 @@ CI:
 enhancement:
 - "src/*.jl"
 - "./*"
-  
-  
-  
- 
-  

.github/workflows/CompatHelper.yml

@@ -12,4 +12,4 @@ jobs:
       - name: CompatHelper.main()
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: julia -e 'using CompatHelper; CompatHelper.main()'
+        run: julia -e 'using CompatHelper; CompatHelper.main()'

.github/workflows/lint.yml

@@ -1,4 +1,4 @@
-name: Lint Markdown
+name: Lint
 
 on: [push, pull_request]
 
@@ -11,5 +11,25 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: '18'
-      - run: npm install -g markdownlint-cli
-      - run: markdownlint '**/*.md' --ignore node_modules
+      - name: "Lint markdown files"
+        run: |
+          npm install -g markdownlint-cli
+          markdownlint '**/*.md' --ignore-path=.gitignore
+      - name: "No trailing whitespaces at EOLs"
+        run: |
+          EXIT_CODE=0
+          git --no-pager grep --full-name -I -n -e ' $' . && EXIT_CODE=1
+          exit $EXIT_CODE
+      - name: "No tab characters"
+        run: |
+          EXIT_CODE=0
+          git --no-pager grep --full-name -I -n -P '\t' . && EXIT_CODE=1
+          exit $EXIT_CODE
+      - name: "Newline at EOF"
+        run: |
+          EXIT_CODE=0
+          for f in $(git --no-pager grep --full-name -I -l ''); do
+            tail -c1 "$f" | read -r _ || echo "$f"
+            tail -c1 "$f" | read -r _ || EXIT_CODE=1
+          done
+          exit $EXIT_CODE

.gitignore

@@ -12,4 +12,4 @@ docs/build
 venv
 *.pyc
 tmp
-gen_resources/build
+gen_resources/build

.markdownlint.yml

@@ -12,3 +12,6 @@ MD026: false
 
 # MD032 Lists should be surrounded by blank lines
 MD032: false
+
+# MD033 Inline HTML
+MD033: false

gen_resources/generate.jl

@@ -18,4 +18,4 @@ build_dir = joinpath(@__DIR__, "build")
 
 artifact_file = joinpath(@__DIR__, "..", "Artifacts.toml")
 
-generate(ARGS, sources, build_dir, artifact_file)
+generate(ARGS, sources, build_dir, artifact_file)

gen_resources/generator/components.jl

@@ -185,4 +185,4 @@ function arg_docstring(prop_name, type_object, required, description, indent_num
             ")",
             isempty(description) ? "" : string(": ", description)
     )
-end
+end

gen_resources/generator/dash.jl

@@ -157,4 +157,4 @@ function components_module_resources(module_name; name, prefix, metadata_file)
     )
 
     return meta
-end
+end

gen_resources/generator/deploy.jl

@@ -152,4 +152,4 @@ function upload_to_releases(repo_name,  tag, tarball_path; attempts = 3)
         end
     end
     error("Unable to upload $(tarball_path) to GitHub repo $(repo_name) on tag $(tag)")
-end
+end

gen_resources/generator/generator.jl

@@ -83,4 +83,4 @@ function generate(ARGS, sources, build_dir, artifact_file)
     end
     @info "resource generation done!"
 
-end
+end