Skip to content

Commit eb54990

Browse files
committed
minor fix
1 parent d3be0f2 commit eb54990

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. This projec
55

66
### [UNRELEASED]
77
### Added
8+
- Support for client side callbacks [#30](https://github.com/plotly/Dash.jl/pull/30)
89
- Support for hot reloading on application or asset changes [#25](https://github.com/plotly/Dash.jl/pull/25)
910
- Asset serving of CSS, JavaScript, and other resources [#18](https://github.com/plotly/Dash.jl/pull/18)
1011
- Support for passing functions as layouts [#18](https://github.com/plotly/Dash.jl/pull/18)

src/app/callbacks.jl

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -60,28 +60,6 @@ end
6060

6161
make_callback_func!(app::DashApp, func::Union{Function, ClientsideFunction}, id::CallbackId) = func
6262

63-
#=
64-
_inline_clientside_template = """
65-
var clientside = window.dash_clientside = window.dash_clientside || {{}};
66-
var ns = clientside["{namespace}"] = clientside["{namespace}"] || {{}};
67-
ns["{function_name}"] = {clientside_function};
68-
"""
69-
70-
out0 = output
71-
if isinstance(output, (list, tuple)):
72-
out0 = output[0]
73-
74-
namespace = "_dashprivate_{}".format(out0.component_id)
75-
function_name = "{}".format(out0.component_property)
76-
77-
self._inline_scripts.append(
78-
_inline_clientside_template.format(
79-
namespace=namespace.replace('"', '\\"'),
80-
function_name=function_name.replace('"', '\\"'),
81-
clientside_function=clientside_function,
82-
)
83-
)
84-
=#
8563
function make_callback_func!(app::DashApp, func::String, id::CallbackId)
8664
first_output = first(id.output)
8765
namespace = replace("_dashprivate_$(first_output[1])", "\""=>"\\\"")

0 commit comments

Comments
 (0)