Skip to content

Commit 439c8aa

Browse files
committed
minor component generator cleanup
1 parent 3e49165 commit 439c8aa

File tree

3 files changed

+11
-21
lines changed

3 files changed

+11
-21
lines changed

dash/development/_jl_components_generation.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -113,20 +113,15 @@ def stringify_wildcards(wclist, no_symbol=False):
113113

114114

115115
def get_wildcards_jl(props):
116-
prop_keys = list(props.keys())
117-
wildcards = []
118-
for key in prop_keys:
119-
if key.endswith("-*"):
120-
wildcards.append(key.replace("-*", ""))
121-
return wildcards
116+
return [key.replace("-*", "") for key in props if key.endswith("-*")]
122117

123118

124119
def get_jl_prop_types(type_object):
125120
"""Mapping from the PropTypes js type object to the Julia type."""
126121

127122
def shape_or_exact():
128123
return "lists containing elements {}.\n{}".format(
129-
", ".join("'{}'".format(t) for t in list(type_object["value"].keys())),
124+
", ".join("'{}'".format(t) for t in type_object["value"]),
130125
"Those elements have the following types:\n{}".format(
131126
"\n".join(
132127
create_prop_docstring_jl(
@@ -136,7 +131,7 @@ def shape_or_exact():
136131
description=prop.get("description", ""),
137132
indent_num=1,
138133
)
139-
for prop_name, prop in list(type_object["value"].items())
134+
for prop_name, prop in type_object["value"].items()
140135
)
141136
),
142137
)
@@ -265,11 +260,8 @@ def create_docstring_jl(component_name, props, description):
265260
# Ensure props are ordered with children first
266261
props = reorder_props(props=props)
267262

268-
return (
269-
"""A{n} {name} component.\n{description}
270-
Keyword arguments:\n{args}"""
271-
).format(
272-
n="n" if component_name[0].lower() in ["a", "e", "i", "o", "u"] else "",
263+
return ("A{n} {name} component.\n{description}\nKeyword arguments:\n{args}").format(
264+
n="n" if component_name[0].lower() in "aeiou" else "",
273265
name=component_name,
274266
description=description,
275267
args="\n".join(
@@ -280,7 +272,7 @@ def create_docstring_jl(component_name, props, description):
280272
description=prop["description"],
281273
indent_num=0,
282274
)
283-
for p, prop in list(filter_props(props).items())
275+
for p, prop in filter_props(props).items()
284276
),
285277
)
286278

dash/development/_py_components_generation.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,11 +225,9 @@ def create_docstring(component_name, props, description):
225225
props = reorder_props(props=props)
226226

227227
return (
228-
"""A{n} {name} component.\n{description}
229-
230-
Keyword arguments:\n{args}"""
228+
"A{n} {name} component.\n{description}\n\nKeyword arguments:\n{args}"
231229
).format(
232-
n="n" if component_name[0].lower() in ["a", "e", "i", "o", "u"] else "",
230+
n="n" if component_name[0].lower() in "aeiou" else "",
233231
name=component_name,
234232
description=description,
235233
args="\n".join(
@@ -242,7 +240,7 @@ def create_docstring(component_name, props, description):
242240
indent_num=0,
243241
is_flow_type="flowType" in prop and "type" not in prop,
244242
)
245-
for p, prop in list(filter_props(props).items())
243+
for p, prop in filter_props(props).items()
246244
),
247245
)
248246

dash/development/_r_components_generation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ def get_r_prop_types(type_object):
846846

847847
def shape_or_exact():
848848
return "lists containing elements {}.\n{}".format(
849-
", ".join("'{}'".format(t) for t in list(type_object["value"].keys())),
849+
", ".join("'{}'".format(t) for t in type_object["value"]),
850850
"Those elements have the following types:\n{}".format(
851851
"\n".join(
852852
create_prop_docstring_r(
@@ -856,7 +856,7 @@ def shape_or_exact():
856856
description=prop.get("description", ""),
857857
indent_num=1,
858858
)
859-
for prop_name, prop in list(type_object["value"].items())
859+
for prop_name, prop in type_object["value"].items()
860860
)
861861
),
862862
)

0 commit comments

Comments
 (0)