Skip to content

Commit c558586

Browse files
committed
Remove test filter; clean up comments
1 parent e761c27 commit c558586

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

R/ggplotly.R

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,8 @@ gg2list <- function(p){
259259
ys <- lapply(trace.list, "[[", "y")
260260
xs <- lapply(trace.list, "[[", "x")
261261
x.vals <- unique(unlist(xs))
262-
# if there is more than one y-value (for a particular x value)
263-
# then
264-
#
262+
# if there is more than one y-value (for a particular x value),
263+
# then modify those y-values so they *add up* to the correct value(s)
265264
for (val in x.vals) {
266265
zs <- lapply(xs, function(x) which(x == val))
267266
ys.given.x <- Map(function(x, y) y[x], zs, ys)
@@ -277,17 +276,6 @@ gg2list <- function(p){
277276
}
278277
}
279278
}
280-
281-
# lens <- sapply(ys, length)
282-
# && length(trace.list) > 1 && any(lens > 1)) {
283-
# xs <- unlist(xs)
284-
# trace.seq <- seq_along(trace.list)
285-
# idx <- rep(trace.seq, lens)
286-
#
287-
#
288-
# browser()
289-
# diffs <- tapply(unlist(ys), INDEX = xs, unStack)
290-
# for (k in trace.seq) trace.list[[k]]$y <- as.numeric(sapply(diffs, "[", k))
291279

292280
# Bar Gap for histograms should be 0
293281
bargaps <- do.call(c, lapply(trace.list, function (x) x$bargap))

R/trace_generation.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@ geom2trace <- list(
577577
L
578578
},
579579
bar=function(data, params) {
580-
#data <- data[order(data$y), ]
581580
x <- if ("x.name" %in% names(data)) data$x.name else data$x
582581
L <- list(x=x,
583582
y=data$y,

tests/testthat.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ library(testthat)
22
save_outputs <- function(gg, name, ignore_ggplot=FALSE) {
33
print(paste("running", name))
44
}
5-
test_check("plotly", filter = "histogram")
5+
test_check("plotly")

0 commit comments

Comments
 (0)