Skip to content

Commit f1bde4f

Browse files
committed
Solving merge conflict 2
2 parents bd0a25e + 7382c87 commit f1bde4f

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

Diff for: .gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ Rapp.history
44
*~
55
.Rhistory
66
.RData
7+
Makefile

Diff for: NEWS

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
0.5.5 -- 23 October 2014.
1+
0.5.6 -- 25 October 2014.
22

33
Lines: fix styles and enhanced conversion.
44

5+
0.5.5 -- 24 October 2014.
6+
7+
Support category histograms (with factors).
8+
59
0.5.4 -- 22 October 2014.
610

711
Support conversion of geom_vline().

Diff for: R/trace_generation.R

+4-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ layer2traces <- function(l, d, misc) {
2121
barmode <- "group"
2222
if (g$geom == "bar" || g$geom == "histogram") {
2323
if (l$stat$objname == "bin") {
24-
bargap <- 0
2524
if (g$geom != "histogram") {
2625
warning("You may want to use geom_histogram.")
2726
}
@@ -67,13 +66,15 @@ layer2traces <- function(l, d, misc) {
6766
"%Y-%m-%d %H:%M:%S")
6867
} else if (inherits(data.vec, "factor")) {
6968
## Re-order data so that Plotly gets it right from ggplot2.
70-
g$data <- g$data[order(g$data[[a]]),]
69+
g$data <- g$data[order(g$data[[a]]), ]
7170
data.vec <- data.vec[match(g$data[[a]], as.numeric(data.vec))]
72-
g$prestats.data <- g$prestats.data[order(g$prestats.data[[a]]),]
71+
g$prestats.data <- g$prestats.data[order(g$prestats.data[[a]]), ]
7372
pdata.vec <- pdata.vec[match(g$prestats.data[[a]],
7473
as.numeric(pdata.vec))]
7574
if (length(pdata.vec) == length(data.vec))
7675
pdata.vec <- data.vec
76+
if (!is.factor(pdata.vec))
77+
pdata.vec <- g$prestats.data[[paste0(a, ".name")]]
7778
}
7879
g$data[[a]] <- data.vec
7980
g$prestats.data[[a]] <- pdata.vec

0 commit comments

Comments
 (0)