Skip to content

Commit 0741f9e

Browse files
committed
ohlc and waterfall: use global constants for delta
1 parent 123bbae commit 0741f9e

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

src/traces/ohlc/attributes.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ var extendFlat = require('../../lib').extendFlat;
1313
var scatterAttrs = require('../scatter/attributes');
1414
var dash = require('../../components/drawing/attributes').dash;
1515
var fxAttrs = require('../../components/fx/attributes');
16+
var delta = require('../../constants/delta.js');
1617

17-
var INCREASING_COLOR = '#3D9970';
18-
var DECREASING_COLOR = '#FF4136';
18+
var INCREASING_COLOR = delta.INCREASING.COLOR;
19+
var DECREASING_COLOR = delta.DECREASING.COLOR;
1920

2021
var lineAttrs = scatterAttrs.line;
2122

src/traces/ohlc/hover.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ var Lib = require('../../lib');
1313
var Fx = require('../../components/fx');
1414
var Color = require('../../components/color');
1515
var fillText = require('../../lib').fillText;
16+
var delta = require('../../constants/delta.js');
1617

1718
var DIRSYMBOL = {
18-
increasing: '▲',
19-
decreasing: '▼'
19+
increasing: delta.INCREASING.SYMBOL,
20+
decreasing: delta.DECREASING.SYMBOL
2021
};
2122

2223
function hoverPoints(pointData, xval, yval, hovermode) {

src/traces/waterfall/defaults.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ var handleText = require('../bar/defaults').handleText;
1515
var handleXYDefaults = require('../scatter/xy_defaults');
1616
var attributes = require('./attributes');
1717
var Color = require('../../components/color');
18+
var delta = require('../../constants/delta.js');
1819

19-
var INCREASING_COLOR = '#3D9970';
20-
var DECREASING_COLOR = '#FF4136';
20+
var INCREASING_COLOR = delta.INCREASING.COLOR;
21+
var DECREASING_COLOR = delta.DECREASING.COLOR;
2122
var TOTALS_COLOR = '#4499FF';
2223

2324
function handleDirection(coerce, direction, defaultColor) {

src/traces/waterfall/hover.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@
1111
var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText;
1212
var opacity = require('../../components/color').opacity;
1313
var hoverOnBars = require('../bar/hover').hoverOnBars;
14+
var delta = require('../../constants/delta.js');
1415

1516
var DIRSYMBOL = {
16-
increasing: '▲',
17-
decreasing: '▼'
17+
increasing: delta.INCREASING.SYMBOL,
18+
decreasing: delta.DECREASING.SYMBOL
1819
};
1920

2021
module.exports = function hoverPoints(pointData, xval, yval, hovermode) {

0 commit comments

Comments
 (0)