Skip to content

Commit 10b94bc

Browse files
committed
mv build/ploticon.js -> src/fonts/ploticon.js
where we now expect devs to update icon definitions "by hand", w/o the use of `npm run preprocess`
1 parent 195a849 commit 10b94bc

File tree

7 files changed

+14
-8
lines changed

7 files changed

+14
-8
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ node_modules
22

33
build/*
44
!build/plotcss.js
5-
!build/ploticon.js
65
!build/README.md
76

87
npm-debug.log*

.npmignore

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
build/*
22
!build/plotcss.js
3-
!build/ploticon.js
43
!build/README.md
54

65
devtools

src/components/modebar/buttons.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var Registry = require('../../registry');
1212
var Plots = require('../../plots/plots');
1313
var axisIds = require('../../plots/cartesian/axis_ids');
1414
var Lib = require('../../lib');
15-
var Icons = require('../../../build/ploticon');
15+
var Icons = require('../../fonts/ploticon');
1616

1717
var _ = Lib._;
1818

src/components/modebar/modebar.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var d3 = require('d3');
1313
var isNumeric = require('fast-isnumeric');
1414

1515
var Lib = require('../../lib');
16-
var Icons = require('../../../build/ploticon');
16+
var Icons = require('../../fonts/ploticon');
1717
var Parser = new DOMParser();
1818

1919
/**

src/core.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ register([
6666
]);
6767

6868
// plot icons
69-
exports.Icons = require('../build/ploticon');
69+
exports.Icons = require('./fonts/ploticon');
7070

7171
// unofficial 'beta' plot methods, use at your own risk
7272
exports.Plots = require('./plots/plots');

build/ploticon.js renamed to src/fonts/ploticon.js

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/**
2+
* Copyright 2012-2019, Plotly, Inc.
3+
* All rights reserved.
4+
*
5+
* This source code is licensed under the MIT license found in the
6+
* LICENSE file in the root directory of this source tree.
7+
*/
8+
19
'use strict';
210

311
module.exports = {

tasks/bundle.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ var arg = process.argv[2];
2222
var DEV = (arg === 'dev') || (arg === '--dev');
2323

2424

25-
// Check if style and font build files are there
25+
// Check if style build file is there
2626
var doesFileExist = common.doesFileExist;
27-
if(!doesFileExist(constants.pathToCSSBuild) || !doesFileExist(constants.pathToFontSVG)) {
27+
if(!doesFileExist(constants.pathToCSSBuild)) {
2828
throw new Error([
29-
'build/ is missing one or more files',
29+
'build/plotcss.js is missing',
3030
'Please run `npm run preprocess` first'
3131
].join('\n'));
3232
}

0 commit comments

Comments
 (0)