File tree 2 files changed +8
-1
lines changed
2 files changed +8
-1
lines changed Original file line number Diff line number Diff line change @@ -62,7 +62,10 @@ function calc(gd, trace) {
62
62
ya = AxisIDs . getFromId ( gd , trace . _diag [ i ] [ 1 ] ) ;
63
63
64
64
// if corresponding x & y axes don't have matching types, skip dim
65
- if ( xa && ya && xa . type !== ya . type ) continue ;
65
+ if ( xa && ya && xa . type !== ya . type ) {
66
+ Lib . log ( 'Skipping splom dimension ' + i + ' with conflicting axis types' ) ;
67
+ continue ;
68
+ }
66
69
67
70
if ( xa ) {
68
71
makeCalcdata ( xa , dim ) ;
Original file line number Diff line number Diff line change @@ -409,6 +409,8 @@ describe('Test splom trace calc step:', function() {
409
409
}
410
410
411
411
it ( 'should skip dimensions with conflicting axis types' , function ( ) {
412
+ spyOn ( Lib , 'log' ) . and . callThrough ( ) ;
413
+
412
414
_calc ( {
413
415
dimensions : [ {
414
416
values : [ 1 , 2 , 3 ]
@@ -424,6 +426,8 @@ describe('Test splom trace calc step:', function() {
424
426
425
427
expect ( cd . t . _scene . matrixOptions . data ) . toBeCloseTo2DArray ( [ [ 2 , 1 , 2 ] ] ) ;
426
428
expect ( cd . t . visibleDims ) . toEqual ( [ 1 ] ) ;
429
+ expect ( Lib . log ) . toHaveBeenCalledTimes ( 1 ) ;
430
+ expect ( Lib . log ) . toHaveBeenCalledWith ( 'Skipping splom dimension 0 with conflicting axis types' ) ;
427
431
} ) ;
428
432
} ) ;
429
433
You can’t perform that action at this time.
0 commit comments