revised cases and using defaults in the function

Author: archmoj

package-lock.json

@@ -80,7 +80,7 @@
     "gl-plot2d": "^1.3.1",
     "gl-plot3d": "^1.5.10",
     "gl-pointcloud2d": "^1.0.1",
-    "gl-scatter3d": "git://github.com/gl-vis/gl-scatter3d.git#2e325c43a31c33737bc547ed3fad749c0f995250",
+    "gl-scatter3d": "git://github.com/gl-vis/gl-scatter3d.git#e1d123ef2c7c97a0bce5042b0eade8166cfe21ca",
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
     "gl-streamtube3d": "^1.1.0",

package.json

@@ -160,7 +160,7 @@ var attrs = module.exports = overrideAll({
         colorAttributes('marker')
     ),
 
-    textposition: extendFlat({}, scatterAttrs.textposition, {dflt: 'top center', arrayOk: true}),
+    textposition: extendFlat({}, scatterAttrs.textposition, {dflt: 'top center'}),
     textfont: {
         color: scatterAttrs.textfont.color,
         size: scatterAttrs.textfont.size,

src/traces/scatter3d/attributes.js

@@ -135,25 +135,23 @@ function calculateErrorParams(errors) {
 
 function parseAlignmentX(a) {
     if(a === null || a === undefined) return 0;
-    else if(typeof(a) === 'number') return a;
-    else if(a.indexOf('left') > -1) return -1;
-    else if(a.indexOf('right') > -1) return 1;
-    return 0;
+
+    return (a.indexOf('left')  > -1) ? -1 :
+           (a.indexOf('right') > -1) ? 1 : 0;
 }
 
 function parseAlignmentY(a) {
     if(a === null || a === undefined) return 0;
-    else if(typeof(a) === 'number') return a;
-    else if(a.indexOf('top') > -1) return -1;
-    else if(a.indexOf('bottom') > -1) return 1;
-    return 0;
+
+    return (a.indexOf('top')    > -1) ? -1 :
+           (a.indexOf('bottom') > -1) ? 1 : 0;
 }
 
-function calculateTextOffset(tp) {
+function calculateTextOffset(tp, dflt) {
     // Read out text properties
 
-    var defaultAlignmentX = 0; // center
-    var defaultAlignmentY = -1; // top
+    var defaultAlignmentX = parseAlignmentX(dflt);
+    var defaultAlignmentY = parseAlignmentY(dflt);
 
     var textOffset = [
         defaultAlignmentX,
@@ -268,7 +266,7 @@ function convertPlotlyOptions(scene, data) {
     }
 
     if('textposition' in data) {
-        params.textOffset = calculateTextOffset(data.textposition);
+        params.textOffset = calculateTextOffset(data.textposition, data.dflt);
         params.textColor = formatColor(data.textfont, 1, len);
         params.textSize = formatParam(data.textfont.size, len, Lib.identity, 12);
         params.textFont = data.textfont.family;  // arrayOk === false