Merge pull request #4314 from plotly/fix-box-shift-vertical-one-sided-violins

Fix box/meanline offset for one-sided vertical violins

Author: etpinard

src/traces/violin/plot.js

@@ -139,10 +139,10 @@ module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) {
             bPosPxOffset = 0;
         } else if(hasPositiveSide) {
             bdPosScaled = [0, bdPos * boxWidth / 2];
-            bPosPxOffset = -boxLineWidth;
+            bPosPxOffset = boxLineWidth * {x: 1, y: -1}[t.posLetter];
         } else {
             bdPosScaled = [bdPos * boxWidth / 2, 0];
-            bPosPxOffset = boxLineWidth;
+            bPosPxOffset = boxLineWidth * {x: -1, y: 1}[t.posLetter];
         }
 
         // inner box

test/image/baselines/violin_log_scale.png

@@ -0,0 +1,62 @@
+{
+  "data": [
+    {
+      "type": "violin",
+      "x0": 10,
+      "y": [ 1, 1, 2, 2, 3, 3, 4, 4 ],
+      "box": { "visible": true },
+      "meanline": { "visible": true },
+      "side": "positive"
+    },
+    {
+      "type": "violin",
+      "x0": 100,
+      "y": [ 1, 1, 2, 2, 3, 3, 4, 4 ],
+      "box": { "visible": true },
+      "meanline": { "visible": true },
+      "side": "negative"
+    },
+    {
+      "type": "violin",
+      "y0": 10,
+      "x": [ 1, 1, 2, 2, 3, 3, 4, 4 ],
+      "box": { "visible": true },
+      "meanline": { "visible": true },
+      "side": "positive",
+      "xaxis": "x2",
+      "yaxis": "y2"
+    },
+    {
+      "type": "violin",
+      "y0": 100,
+      "x": [ 1, 1, 2, 2, 3, 3, 4, 4 ],
+      "box": { "visible": true },
+      "meanline": { "visible": true },
+      "side": "negative",
+      "xaxis": "x2",
+      "yaxis": "y2"
+    }
+  ],
+  "layout": {
+    "xaxis": {
+      "ticks": "inside"
+    },
+    "yaxis2": {
+      "ticks": "inside"
+    },
+    "showlegend": false,
+    "grid": {
+      "columns": 2,
+      "rows": 1,
+      "pattern": "independent"
+    },
+    "width": 500,
+    "hieght": 500,
+    "margin": {
+      "t": 40,
+      "l": 40,
+      "r": 40,
+      "b": 40
+    }
+  }
+}