Skip to content

Commit 98d9baa

Browse files
authored
Merge pull request #3591 from plotly/fix-noci-cone-plots
Fixing cone plots lighting & rendering on some hardware including CircleCI image test
2 parents 4877a9c + 9390d82 commit 98d9baa

12 files changed

+5
-6
lines changed

package-lock.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"es6-promise": "^3.0.2",
7373
"fast-isnumeric": "^1.1.2",
7474
"font-atlas-sdf": "^1.3.3",
75-
"gl-cone3d": "^1.2.3",
75+
"gl-cone3d": "^1.3.0",
7676
"gl-contour2d": "^1.1.5",
7777
"gl-error3d": "^1.0.14",
7878
"gl-heatmap2d": "^1.0.5",
-61.9 KB
Loading
-24.1 KB
Loading
-27.6 KB
Loading
Loading
-20.9 KB
Loading
-39.8 KB
Loading
-22 KB
Loading
-13.4 KB
Loading
Loading

test/image/compare_pixels_test.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,7 @@ function untestableFilter(mockName) {
9696
var cond = !(
9797
mockName === 'font-wishlist' ||
9898
mockName.indexOf('gl2d_') !== -1 ||
99-
mockName.indexOf('mapbox_') !== -1 ||
100-
mockName.indexOf('gl3d_cone-') !== -1
99+
mockName.indexOf('mapbox_') !== -1
101100
);
102101

103102
if(!cond) console.log(' -', mockName);

0 commit comments

Comments
 (0)