Skip to content

Commit a6393bc

Browse files
authored
Merge pull request #3932 from plotly/sankey-fix-3813
improve robustness of circular Sankey
2 parents 705b184 + 5fed1a5 commit a6393bc

File tree

7 files changed

+31
-14
lines changed

7 files changed

+31
-14
lines changed

package-lock.json

+11-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"d3-force": "^1.0.6",
6767
"d3-hierarchy": "^1.1.8",
6868
"d3-interpolate": "1",
69-
"d3-sankey-circular": "0.33.0",
69+
"@plotly/d3-sankey-circular": "0.33.1",
7070
"delaunay-triangulate": "^1.1.6",
7171
"es6-promise": "^3.0.2",
7272
"fast-isnumeric": "^1.1.3",

src/traces/sankey/render.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ var tinycolor = require('tinycolor2');
1414
var Color = require('../../components/color');
1515
var Drawing = require('../../components/drawing');
1616
var d3Sankey = require('@plotly/d3-sankey');
17-
var d3SankeyCircular = require('d3-sankey-circular');
17+
var d3SankeyCircular = require('@plotly/d3-sankey-circular');
1818
var d3Force = require('d3-force');
1919
var Lib = require('../../lib');
2020
var gup = require('../../lib/gup');
3.53 KB
Loading
37.1 KB
Loading
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"data": [{
3+
"link": {
4+
"source": [2, 2, 4, 2, 3, 0, 1, 0],
5+
"target": [0, 4, 2, 3, 2, 4, 2, 1],
6+
"value": [1, 1, 1, 1, 1, 1, 1, 1]
7+
},
8+
"node": {
9+
"label": ["A", "B", "C", "D", "E"]
10+
},
11+
"type": "sankey"
12+
}],
13+
"layout": {
14+
"width": 800,
15+
"height": 800
16+
}
17+
}

test/jasmine/tests/sankey_test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var attributes = require('@src/traces/sankey/attributes');
33
var Lib = require('@src/lib');
44
var d3 = require('d3');
55
var d3sankey = require('@plotly/d3-sankey');
6-
var d3SankeyCircular = require('d3-sankey-circular');
6+
var d3SankeyCircular = require('@plotly/d3-sankey-circular');
77
var mock = require('@mocks/sankey_energy.json');
88
var mockDark = require('@mocks/sankey_energy_dark.json');
99
var mockCircular = require('@mocks/sankey_circular.json');

0 commit comments

Comments
 (0)