Skip to content

Commit b8ea71e

Browse files
committed
improve comments
1 parent 3776cd2 commit b8ea71e

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/traces/histogram/calc.js

+1
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ function calcAllAutoBins(gd, trace, pa, mainData, _overlayEdgeCase) {
292292
}
293293

294294
// TODO how does work with bingroup ????
295+
// - https://github.com/plotly/plotly.js/issues/3881
295296
//
296297
// Edge case: single-valued histogram overlaying others
297298
// Use them all together to calculate the bin size for the single-valued one

test/jasmine/tests/histogram_test.js

-2
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,6 @@ describe('Test histogram', function() {
378378
]);
379379
});
380380

381-
// TODO figure out what to do in this case!
382381
it('should be able to group histogram and histogram2d* traces together', function() {
383382
gd = {
384383
data: [
@@ -447,7 +446,6 @@ describe('Test histogram', function() {
447446
{bingroup: '1', type: 'histogram', y: [2, 3], xaxis: 'x2', yaxis: 'y2'},
448447
// this one does not have to match either
449448
// (it's a histogram2d* traces), but it can be grouped
450-
// TODO should this be just "bingroup"???
451449
{xbingroup: '1', ybingroup: '1', type: 'histogram2d', x: [3, 4], y: [3, 4]}
452450
],
453451
layout: {}

0 commit comments

Comments
 (0)