Skip to content

Commit c2ecb3a

Browse files
committed
🔪 obsolete args
1 parent 5878223 commit c2ecb3a

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/plot_api/plot_api.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ exports.plot = function(gd, data, layout, config) {
269269
Lib.error(msg);
270270
} else {
271271
Lib.log(msg + ' Clearing graph and plotting again.');
272-
Plots.cleanPlot([], {}, gd._fullData, fullLayout, gd.calcdata);
272+
Plots.cleanPlot([], {}, gd._fullData, fullLayout);
273273
Plots.supplyDefaults(gd);
274274
fullLayout = gd._fullLayout;
275275
Plots.doCalcdata(gd);
@@ -614,7 +614,7 @@ exports.newPlot = function(gd, data, layout, config) {
614614
gd = Lib.getGraphDiv(gd);
615615

616616
// remove gl contexts
617-
Plots.cleanPlot([], {}, gd._fullData || [], gd._fullLayout || {}, gd.calcdata || []);
617+
Plots.cleanPlot([], {}, gd._fullData || [], gd._fullLayout || {});
618618

619619
Plots.purge(gd);
620620
return exports.plot(gd, data, layout, config);
@@ -3199,10 +3199,9 @@ exports.purge = function purge(gd) {
31993199

32003200
var fullLayout = gd._fullLayout || {};
32013201
var fullData = gd._fullData || [];
3202-
var calcdata = gd.calcdata || [];
32033202

32043203
// remove gl contexts
3205-
Plots.cleanPlot([], {}, fullData, fullLayout, calcdata);
3204+
Plots.cleanPlot([], {}, fullData, fullLayout);
32063205

32073206
// purge properties
32083207
Plots.purge(gd);

src/plots/plots.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ plots.supplyDefaults = function(gd, opts) {
467467
plots.linkSubplots(newFullData, newFullLayout, oldFullData, oldFullLayout);
468468

469469
// clean subplots and other artifacts from previous plot calls
470-
plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata);
470+
plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout);
471471

472472
// relink functions and _ attributes to promote consistency between plots
473473
relinkPrivateKeys(newFullLayout, oldFullLayout);
@@ -714,15 +714,15 @@ plots._hasPlotType = function(category) {
714714
return false;
715715
};
716716

717-
plots.cleanPlot = function(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata) {
717+
plots.cleanPlot = function(newFullData, newFullLayout, oldFullData, oldFullLayout) {
718718
var i, j;
719719

720720
var basePlotModules = oldFullLayout._basePlotModules || [];
721721
for(i = 0; i < basePlotModules.length; i++) {
722722
var _module = basePlotModules[i];
723723

724724
if(_module.clean) {
725-
_module.clean(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata);
725+
_module.clean(newFullData, newFullLayout, oldFullData, oldFullLayout);
726726
}
727727
}
728728

0 commit comments

Comments
 (0)