Merge pull request #1686 from plotly/fix-mesh3d-vertexcolor

Get mesh3d vertexcolor in a working state!

Author: etpinard

src/traces/mesh3d/attributes.js

@@ -125,7 +125,7 @@ module.exports = {
         description: 'Sets the color of the whole mesh'
     },
     vertexcolor: {
-        valType: 'data_array',  // FIXME: this should be a color array
+        valType: 'data_array',
         role: 'style',
         description: [
             'Sets the color of each vertex',

src/traces/mesh3d/convert.js

@@ -127,7 +127,7 @@ proto.update = function(data) {
         config.colormap = parseColorScale(data.colorscale);
     }
     else if(data.vertexcolor) {
-        this.color = data.vertexcolors[0];
+        this.color = data.vertexcolor[0];
         config.vertexColors = parseColorArray(data.vertexcolor);
     }
     else if(data.facecolor) {

src/traces/mesh3d/defaults.js

@@ -82,8 +82,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     else {
         traceOut.showscale = false;
 
-        if('vertexcolor' in traceIn) coerce('vertexcolor');
-        else if('facecolor' in traceIn) coerce('facecolor');
+        if('facecolor' in traceIn) coerce('facecolor');
+        else if('vertexcolor' in traceIn) coerce('vertexcolor');
         else coerce('color', defaultColor);
     }
 

test/image/baselines/gl3d_tet.png

@@ -0,0 +1,87 @@
+{
+  "data": [
+    {
+      "type":"mesh3d",
+      "name": "colorscale + intensity",
+      "x":[0, 1, 2, 0],
+      "y":[0, 0, 1, 2],
+      "z":[0, 2, 0, 1],
+      "i":[0, 0, 0, 1],
+      "j":[1, 2, 3, 2],
+      "k":[2, 3, 1, 3],
+      "colorscale": [
+        [0, "rgb(0, 0, 0)"],
+        [0.33, "rgb(255, 0, 0)"],
+        [0.66, "rgb(0, 255, 0)"],
+        [1, "rgb(0, 0, 255)"]
+      ],
+      "intensity": [0, 0.33, 0.66, 1],
+      "colorbar": {
+        "x": 0,
+        "title": "for colorscale + intensity tetrahedra",
+        "titleside": "right"
+      }
+    }, 
+    {
+      "type":"mesh3d",
+      "name": "facecolor",
+      "x":[3, 4, 5, 3],
+      "y":[0, 0, 1, 2],
+      "z":[0, 2, 0, 1],
+      "i":[0, 0, 0, 1],
+      "j":[1, 2, 3, 2],
+      "k":[2, 3, 1, 3],
+      "facecolor": [
+        "rgb(0, 0, 0)",
+        "rgb(255, 0, 0)",
+        "rgb(0, 255, 0)",
+        "rgb(0, 0, 255)"
+      ]
+    },
+    {
+      "type":"mesh3d",
+      "name": "vertexcolor",
+      "x":[6, 7, 8, 6],
+      "y":[0, 0, 1, 2],
+      "z":[0, 2, 0, 1],
+      "i":[0, 0, 0, 1],
+      "j":[1, 2, 3, 2],
+      "k":[2, 3, 1, 3],
+      "vertexcolor": [
+        "rgb(0, 0, 0)",
+        "rgb(255, 0, 0)",
+        "rgb(0, 255, 0)",
+        "rgb(0, 0, 255)"
+      ]
+    },
+    {
+      "type":"mesh3d",
+      "name": "color",
+      "x":[9, 10, 11, 9],
+      "y":[0, 0, 1, 2],
+      "z":[0, 2, 0, 1],
+      "i":[0, 0, 0, 1],
+      "j":[1, 2, 3, 2],
+      "k":[2, 3, 1, 3],
+      "color": "rgb(0, 255, 0)"
+    }
+  ],
+  "layout": {
+    "title": "Tetrahedra",
+    "scene": {
+        "aspectratio": {
+          "x": 5,
+          "y": 1,
+          "z": 1
+        },
+        "camera": {
+            "eye": {
+                "x": 0,
+                "y": -3,
+                "z": 1.8
+            }
+        }
+    },
+    "width": 1000
+  }
+}