Skip to content

Commit cb40618

Browse files
committed
pie: accept emptry string in helpers.getFirstFilled
1 parent 2e966e0 commit cb40618

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/traces/pie/helpers.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ exports.getFirstFilled = function getFirstFilled(array, indices) {
3030
if(!Array.isArray(array)) return;
3131
for(var i = 0; i < indices.length; i++) {
3232
var v = array[indices[i]];
33-
if(v || v === 0) return v;
33+
if(v || v === 0 || v === '') return v;
3434
}
3535
};
3636

src/traces/pie/plot.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,7 @@ function formatSliceLabel(gd, pt, cd0) {
991991
pt.text = '';
992992
} else {
993993
var obj = makeTemplateVariables(pt);
994-
var ptTx = Lib.castOption(trace, pt.i, 'text');
994+
var ptTx = helpers.getFirstFilled(trace.text, pt.pts);
995995
if(isValidTextValue(ptTx) || ptTx === '') obj.text = ptTx;
996996
pt.text = Lib.texttemplateString(txt, obj, gd._fullLayout._d3locale, obj, trace._meta || {});
997997
}

0 commit comments

Comments
 (0)