Skip to content

Commit d7c1434

Browse files
committed
Flag click-to-select tests of gl-based traces with @gl [1852]
1 parent 2f7ad27 commit d7c1434

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

test/jasmine/tests/select_test.js

+12-6
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ describe('Click-to-select', function() {
374374
.then(done);
375375
});
376376

377-
it('@flaky works in a multi-trace plot', function(done) {
377+
it('@gl works in a multi-trace plot', function(done) {
378378
Plotly.plot(gd, [
379379
{
380380
x: [1, 3, 5, 4, 10, 12, 12, 7],
@@ -474,7 +474,7 @@ describe('Click-to-select', function() {
474474
.then(done);
475475
});
476476

477-
it('@flaky is supported by scattergl in pan/zoom mode', function(done) {
477+
it('@gl is supported by scattergl in pan/zoom mode', function(done) {
478478
Plotly.plot(gd, [
479479
{
480480
x: [7, 8, 9, 10],
@@ -630,11 +630,12 @@ describe('Click-to-select', function() {
630630
testCase('scatterpolar', require('@mocks/polar_scatter.json'), 130, 290,
631631
[[], [], [], [19], [], []], { dragmode: 'zoom' }),
632632
testCase('scatterpolargl', require('@mocks/glpolar_scatter.json'), 130, 290,
633-
[[], [], [], [19], [], []], { dragmode: 'zoom' }),
634-
testCase('splom', require('@mocks/splom_lower.json'), 427, 400, [[], [7], []])
633+
[[], [], [], [19], [], []], { dragmode: 'zoom' }).enableGl(),
634+
testCase('splom', require('@mocks/splom_lower.json'), 427, 400, [[], [7], []]).enableGl()
635635
]
636636
.forEach(function(testCase) {
637-
it('@flaky trace type ' + testCase.traceType, function(done) {
637+
var ciAnnotation = testCase.gl ? 'gl' : 'flaky';
638+
it('@' + ciAnnotation + ' trace type ' + testCase.traceType, function(done) {
638639
var defaultLayoutOpts = {
639640
layout: {
640641
clickmode: 'event+select',
@@ -687,7 +688,12 @@ describe('Click-to-select', function() {
687688
x: x,
688689
y: y,
689690
expectedPts: expectedPts,
690-
configOptions: configOptions
691+
configOptions: configOptions,
692+
gl: false,
693+
enableGl: function() {
694+
this.gl = true;
695+
return this;
696+
}
691697
};
692698
}
693699
});

0 commit comments

Comments
 (0)