Merge pull request #3187 from plotly/custom-modebar-ie11-fix

Fix modebar <style> update in IE11

Author: etpinard

src/lib/index.js

@@ -713,7 +713,7 @@ lib.addRelatedStyleRule = function(uid, selector, styleString) {
 lib.deleteRelatedStyleRule = function(uid) {
     var id = 'plotly.js-style-' + uid,
         style = document.getElementById(id);
-    if(style) style.remove();
+    if(style) lib.removeElement(style);
 };
 
 lib.isIE = function() {

test/jasmine/assets/unpolyfill.js

@@ -0,0 +1,22 @@
+/*
+ * Un-polyfills - to be included in karma.conf.js to catch
+ * browser-dependent errors.
+ */
+
+'use strict';
+
+(function(arr) {
+    arr.forEach(function(item) {
+        Object.defineProperty(item, 'remove', {
+            configurable: true,
+            enumerable: true,
+            writable: true,
+            value: function remove() {
+                throw Error([
+                    'test/jasmine/assets/unpolyfill.js error: calling ChildNode.remove()',
+                    'which is not available in IE.'
+                ].join(' '));
+            }
+        });
+    });
+})([Element.prototype, CharacterData.prototype, DocumentType.prototype]);

test/jasmine/karma.conf.js

@@ -106,6 +106,7 @@ var pathToStrictD3 = path.join(__dirname, '..', '..', 'tasks', 'util', 'strict_d
 var pathToJQuery = path.join(__dirname, 'assets', 'jquery-1.8.3.min.js');
 var pathToIE9mock = path.join(__dirname, 'assets', 'ie9_mock.js');
 var pathToCustomMatchers = path.join(__dirname, 'assets', 'custom_matchers.js');
+var pathToUnpolyfill = path.join(__dirname, 'assets', 'unpolyfill.js');
 
 var reporters = (isFullSuite && !argv.tags) ? ['dots', 'spec'] : ['progress'];
 if(argv.failFast) reporters.push('fail-fast');
@@ -142,7 +143,7 @@ func.defaultConfig = {
     // list of files / patterns to load in the browser
     //
     // N.B. the rest of this field is filled below
-    files: [pathToCustomMatchers],
+    files: [pathToCustomMatchers, pathToUnpolyfill],
 
     // list of files / pattern to exclude
     exclude: [],