Skip to content

Commit f2e80a7

Browse files
committed
Make direct fill update
1 parent 64f112f commit f2e80a7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

package-lock.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"polybooljs": "^1.2.0",
100100
"regl": "^1.3.1",
101101
"regl-error2d": "^2.0.3",
102-
"regl-line2d": "^2.1.4",
102+
"regl-line2d": "^2.1.5",
103103
"regl-scatter2d": "^2.1.16",
104104
"right-now": "^1.0.0",
105105
"robust-orientation": "^1.1.3",

src/traces/scattergl/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -781,9 +781,9 @@ function plot(container, subplot, cdata) {
781781
}
782782
// fill requires linked traces, so we generate it's positions here
783783
if(scene.fill2d) {
784-
var fillOptions = scene.fillOptions.map(function(fillOptions, i) {
784+
scene.fillOptions = scene.fillOptions.map(function(fillOptions, i) {
785785
var cdscatter = cdata[i];
786-
if(!fillOptions || !cdscatter || !cdscatter[0] || !cdscatter[0].trace) return {positions: []};
786+
if(!fillOptions || !cdscatter || !cdscatter[0] || !cdscatter[0].trace) return null;
787787
var cd = cdscatter[0];
788788
var trace = cd.trace;
789789
var stash = cd.t;
@@ -867,7 +867,7 @@ function plot(container, subplot, cdata) {
867867
return fillOptions;
868868
});
869869

870-
scene.fill2d.update(fillOptions);
870+
scene.fill2d.update(scene.fillOptions);
871871
}
872872
}
873873

0 commit comments

Comments
 (0)