From 48ce05cbc274948665715bce02cf02ab708134bd Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Tue, 21 Jan 2025 11:04:42 -0600 Subject: [PATCH 1/4] Create github action to run noci tests --- .github/workflows/test.yml | 32 ++++++++++++++++++++++++++++++++ .gitignore | 1 + 2 files changed, 33 insertions(+) create mode 100644 .github/workflows/test.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 00000000000..86320b6536f --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,32 @@ +# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node +# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs + +name: No CI Test + +on: + push: + branches: [ $default-branch ] + pull_request: + branches: [ $default-branch ] + +jobs: + build: + + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [18.x] + + steps: + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: 'npm' + - run: ls + - run: npm run pretest + - run: npm ci + - run: npm run cibuild + - run: ./tasks/noci_test.sh \ No newline at end of file diff --git a/.gitignore b/.gitignore index 02e1f10c3e7..505aaa57cd1 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,4 @@ tags !.circleci !.gitignore !.npmignore +!.github From 022674e85c5e4f829af3c3d6d59484b75634c113 Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Tue, 21 Jan 2025 11:08:35 -0600 Subject: [PATCH 2/4] Run on any push --- .github/workflows/test.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 86320b6536f..2edf8726c13 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -3,11 +3,7 @@ name: No CI Test -on: - push: - branches: [ $default-branch ] - pull_request: - branches: [ $default-branch ] +on: push jobs: build: From d823caf5d48e4af6926e18d9a057e8ee550ccccd Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Tue, 21 Jan 2025 11:19:08 -0600 Subject: [PATCH 3/4] Add chrome install --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2edf8726c13..af362717b1a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,12 +15,14 @@ jobs: node-version: [18.x] steps: + - uses: browser-actions/setup-chrome@v1 - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: 'npm' + - run: chrome --version - run: ls - run: npm run pretest - run: npm ci From 755540d0e0d0f6a79bb37607d6b63f63cfed2faf Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Tue, 21 Jan 2025 11:41:04 -0600 Subject: [PATCH 4/4] try including xvfb to run tests headless --- .github/workflows/test.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index af362717b1a..c214635983c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,4 +27,7 @@ jobs: - run: npm run pretest - run: npm ci - run: npm run cibuild - - run: ./tasks/noci_test.sh \ No newline at end of file + - name: Run headless test + uses: coactions/setup-xvfb@v1 + with: + run: ./tasks/noci_test.sh \ No newline at end of file