Skip to content

Commit 096cba8

Browse files
committed
Fix for Python 4: do not compare sys.version_info.minor to integer
1 parent 8471732 commit 096cba8

File tree

17 files changed

+16
-19
lines changed

17 files changed

+16
-19
lines changed

packages/python/chart-studio/chart_studio/tests/test_plot_ly/test_api/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import sys
99

1010
# import from mock
11-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
11+
if sys.version_info.major >= 3:
1212
from unittest.mock import patch
1313
else:
1414
from mock import patch

packages/python/chart-studio/chart_studio/tests/test_plot_ly/test_plotly/test_credentials.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import sys
1010

1111
# import from mock
12-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
12+
if sys.version_info.major >= 3:
1313
from unittest.mock import patch
1414
else:
1515
from mock import patch

packages/python/chart-studio/chart_studio/tests/test_plot_ly/test_plotly/test_plot.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
# import from mock
28-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
28+
if sys.version_info.major >= 3:
2929
from unittest.mock import patch
3030
else:
3131
from mock import patch

packages/python/plotly/_plotly_utils/utils.py

-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
from _plotly_utils.basevalidators import ImageUriValidator
88

99

10-
PY36_OR_LATER = sys.version_info.major == 3 and sys.version_info.minor >= 6
11-
12-
1310
class PlotlyJSONEncoder(_json.JSONEncoder):
1411
"""
1512
Meant to be passed as the `cls` kwarg to json.dumps(obj, cls=..)

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_add_traces.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import plotly.graph_objs as go
55

6-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
6+
if sys.version_info.major >= 3:
77
from unittest.mock import MagicMock
88
else:
99
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_batch_animate.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import plotly.graph_objs as go
55

6-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
6+
if sys.version_info.major >= 3:
77
from unittest.mock import MagicMock
88
else:
99
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_move_delete_traces.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import plotly.graph_objs as go
66

7-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
7+
if sys.version_info.major >= 3:
88
from unittest.mock import MagicMock
99
else:
1010
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_on_change.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import plotly.graph_objs as go
66

7-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
7+
if sys.version_info.major >= 3:
88
from unittest.mock import MagicMock
99
else:
1010
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_plotly_relayout.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import plotly.graph_objs as go
55

6-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
6+
if sys.version_info.major >= 3:
77
from unittest.mock import MagicMock
88
else:
99
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_plotly_restyle.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import plotly.graph_objs as go
55

6-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
6+
if sys.version_info.major >= 3:
77
from unittest.mock import MagicMock
88
else:
99
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_figure_messages/test_plotly_update.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import plotly.graph_objs as go
55
from plotly.basedatatypes import Undefined
66

7-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
7+
if sys.version_info.major >= 3:
88
from unittest.mock import MagicMock
99
else:
1010
from mock import MagicMock

packages/python/plotly/plotly/tests/test_core/test_optional_imports/test_optional_imports.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_get_module_import_exception(self):
2727
# Get module that raises an exception on import
2828
module_str = "plotly.tests.test_core." "test_optional_imports.exploding_module"
2929

30-
if sys.version_info.major == 3 and sys.version_info.minor >= 4:
30+
if sys.version_info >= (3, 4):
3131
with self.assertLogs("_plotly_utils.optional_imports", level="ERROR") as cm:
3232
module = get_module(module_str)
3333

packages/python/plotly/plotly/tests/test_io/test_renderers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import plotly.io as pio
1313
from plotly.offline import get_plotlyjs
1414

15-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
15+
if sys.version_info.major >= 3:
1616
import unittest.mock as mock
1717
from unittest.mock import MagicMock
1818
else:

packages/python/plotly/plotly/tests/test_io/test_to_from_json.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import sys
77
import os
88

9-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
9+
if sys.version_info.major >= 3:
1010
from unittest.mock import MagicMock
1111
import tempfile
1212
else:

packages/python/plotly/plotly/tests/test_orca/test_image_renderers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from plotly.offline.offline import _get_jconfig
1212

13-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
13+
if sys.version_info.major >= 3:
1414
import unittest.mock as mock
1515
else:
1616
import mock

packages/python/plotly/plotly/tests/test_orca/test_to_image.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import sys
88
import pandas as pd
99

10-
if sys.version_info.major == 3 and sys.version_info.minor >= 3:
10+
if sys.version_info.major >= 3:
1111
from unittest.mock import MagicMock
1212
else:
1313
from mock import MagicMock

packages/python/plotly/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def finalize_options(self):
161161
pass
162162

163163
def run(self):
164-
if sys.version_info.major != 3 or sys.version_info.minor < 6:
164+
if sys.version_info < (3, 6):
165165
raise ImportError("Code generation must be executed with Python >= 3.6")
166166

167167
from codegen import perform_codegen

0 commit comments

Comments
 (0)